Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] Small fix in checkbox logic #1453

Merged
merged 1 commit into from
May 10, 2019
Merged

[Checkbox] Small fix in checkbox logic #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Code quality

- Simplified logic in Checkbox component ([#1453](https://github.com/Shopify/polaris-react/pull/1453))

### Deprecations
2 changes: 1 addition & 1 deletion src/components/Checkbox/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ class Checkbox extends React.PureComponent<CombinedProps, never> {

componentDidUpdate({disabled: prevDisabled}: Props) {
if (
prevDisabled === true &&
this.props.disabled &&
!prevDisabled !== true &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes my eyes go crossed. Good fix

Copy link
Contributor Author

@keyfer keyfer May 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously could just make this prevDisabled &&, but I'd rather avoid Type Coercion.

this.inputNode.current &&
this.inputNode.current.checked
) {
Expand Down