Trial combination of bouwe array-equal-fix and non-lazy-benchmarks #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
added
the
benchmark_this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6349 +/- ##
=======================================
Coverage 89.79% 89.80%
=======================================
Files 90 90
Lines 23554 23576 +22
Branches 4391 4399 +8
=======================================
+ Hits 21150 21172 +22
Misses 1662 1662
Partials 742 742 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
⏱️ Performance Benchmark Report: 0327e4ePerformance shiftsFull benchmark resultsGenerated by GHA run |
Update after re-benchmark runthe #6337 speedups were about -20%..-30%, so roughly cancel out the slowdowns. All of this is pretty much just the same as what we saw before. |
pp-mo
added
benchmark_this
|
Rebased from updated #6325 with added commit "@bouweandela And re-started benchmarks ... |
⏱️ Performance Benchmark Report: 84c20d0Performance shiftsFull benchmark resultsGenerated by GHA run |
bouweandela
added
benchmark_this
⏱️ Performance Benchmark Report: 0d3239bPerformance shiftsFull benchmark resultsGenerated by GHA run |
bouweandela
added
benchmark_this
⏱️ Performance Benchmark Report: 842be13Performance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My manual merge of #6325 and #6339 just to see how performance is affected.
NB since I already merged #6337 the benefit from that has already been had.
So, if this benchmarks slower in the expected cases, we should reference to those improvements too, since they were intended to mitigate possible costs of #6325