Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use realized data in benchmarks when requested #6339

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Use realized data in benchmarks when requested #6339

merged 3 commits into from
Mar 6, 2025

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Benchmarking with realized data did not actually happen. This pull request updates the patch method so realized data is used in benchmarks that request it. Note that this does not apply to derived coordinates, which are always lazy.

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (a93085d) to head (6cc8e50).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6339   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files          90       90           
  Lines       23548    23548           
  Branches     4391     4391           
=======================================
  Hits        21143    21143           
  Misses       1662     1662           
  Partials      743      743

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela bouweandela added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

⏱️ Performance Benchmark Report: 2192362

Performance shifts
Full benchmark results 

Benchmarks that have stayed the same:

| Change   | Before [d1032300]    | After [21923627]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 21.0±0.3ms           | 21.1±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 60.2±0.9ms           | 58.9±0.5ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 34.3±0.3ms           | 34.4±0.5ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 205±3ms              | 197±3ms             |    0.96 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 23.4±0.5ms           | 22.6±0.5ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 38.9±1ms             | 37.9±0.2ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 23.0±0.2ms           | 23.0±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 39.0±1ms             | 38.1±0.8ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 20.8±0.3ms           | 21.0±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 51.5±0.5ms           | 51.6±0.6ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 129±1ms              | 128±0.6ms           |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 139±2ms              | 137±1ms             |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 22.1±0.3ms           | 22.3±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 57.1±0.9ms           | 56.1±0.7ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 24.2±0.2ms           | 23.6±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 64.1±1ms             | 63.5±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 20.9±0.2ms           | 20.9±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 52.1±0.8ms           | 51.1±0.8ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.08±0.01s           | 1.08±0.01s          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.09±0.02s           | 1.09±0s             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 210±4ms              | 210±2ms             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 499±10ms             | 490±9ms             |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 22.1±0.3ms           | 21.7±0.5ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 37.4±1ms             | 36.4±0.5ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 22.6±0.3ms           | 22.1±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 66.9±0.8ms           | 66.0±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 23.0±0.2ms           | 23.1±0.3ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 69.6±1ms             | 69.0±0.9ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 23.1±0.2ms           | 23.1±0.2ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 65.2±1ms             | 65.0±0.7ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 7.41±0.06ms          | 7.39±0.08ms         |    1    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 29.2±0.7ms           | 29.2±0.5ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 18.5±0.1ms           | 18.8±0.3ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 145±7ms              | 144±2ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 7.83±0.1ms           | 7.94±0.06ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 27.2±1ms             | 26.8±0.1ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 7.78±0.06ms          | 7.79±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 26.8±1ms             | 27.0±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 7.34±0.09ms          | 7.33±0.1ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 27.9±0.4ms           | 28.1±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 23.7±0.1ms           | 23.7±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 40.9±0.8ms           | 40.8±0.5ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 7.67±0.1ms           | 7.72±0.1ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 28.4±0.8ms           | 28.3±0.2ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 9.05±0.1ms           | 9.13±0.1ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 30.6±0.6ms           | 30.8±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 7.44±0.08ms          | 7.34±0.1ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 27.8±0.6ms           | 27.6±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 526±4ms              | 528±2ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 547±2ms              | 548±5ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 44.1±0.4ms           | 43.2±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 164±6ms              | 164±1ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 7.71±0.05ms          | 7.73±0.05ms         |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 27.1±0.9ms           | 26.5±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 7.70±0.08ms          | 7.81±0.03ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 29.8±0.8ms           | 30.1±0.3ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 7.83±0.04ms          | 7.92±0.08ms         |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 29.7±1ms             | 29.7±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 8.00±0.1ms           | 8.06±0.2ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 29.1±1ms             | 29.3±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 22.5±0.3ms           | 22.5±0.3ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 92.2±2ms             | 92.5±1ms            |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 22.8±0.4ms           | 22.3±0.3ms          |    0.98 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 106±2ms              | 106±0.8ms           |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 21.4±0.2ms           | 21.4±0.09ms         |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 62.3±0.9ms           | 62.6±0.9ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 7.97±0.05ms          | 7.92±0.1ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 34.3±1ms             | 34.4±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 7.97±0.1ms           | 7.92±0.04ms         |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 35.4±1ms             | 35.2±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 7.69±0.1ms           | 7.69±0.07ms         |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 29.8±0.5ms           | 29.7±0.1ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 213±4ms              | 215±4ms             |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 336±3ms              | 330±4ms             |    0.98 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.07±0.01ms          | 1.07±0.01ms         |    1    | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 381±8μs              | 384±10μs            |    1.01 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 911±7μs              | 927±6μs             |    1.02 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 548±8μs              | 552±10μs            |    1.01 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 133±1ms              | 134±1ms             |    1    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 66.2±0.8ms           | 67.2±1ms            |    1.02 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 140±2ms              | 141±0.9ms           |    1.01 | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.5±0.3μs           | 16.3±0.2μs          |    0.99 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 134±3ms              | 134±1ms             |    1    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 66.2±1ms             | 66.2±0.9ms          |    1    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 141±2ms              | 141±2ms             |    1    | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 16.3±0.1μs           | 16.5±0.2μs          |    1.01 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 226±2ms              | 226±3ms             |    1    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 119±2ms              | 121±2ms             |    1.02 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 250±5ms              | 251±5ms             |    1.01 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 51.0±0.6μs           | 50.9±0.3μs          |    1    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 310±9ms              | 315±5ms             |    1.02 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 204±2ms              | 206±4ms             |    1.01 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 336±7ms              | 336±6ms             |    1    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 52.3±0.5μs           | 52.0±0.6μs          |    0.99 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 805±9μs              | 808±5μs             |    1    | import_iris.Iris.time__concatenate                                                          |
|          | 184±3μs              | 191±4μs             |    1.04 | import_iris.Iris.time__constraints                                                          |
|          | 116±2μs              | 114±0.6μs           |    0.99 | import_iris.Iris.time__data_manager                                                         |
|          | 91.0±0.4μs           | 92.3±2μs            |    1.02 | import_iris.Iris.time__deprecation                                                          |
|          | 164±3μs              | 165±2μs             |    1.01 | import_iris.Iris.time__lazy_data                                                            |
|          | 912±7μs              | 916±20μs            |    1    | import_iris.Iris.time__merge                                                                |
|          | 73.4±0.6μs           | 73.5±2μs            |    1    | import_iris.Iris.time__representation                                                       |
|          | 601±4μs              | 599±7μs             |    1    | import_iris.Iris.time_analysis                                                              |
|          | 139±2μs              | 144±3μs             |    1.03 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 107±0.5μs            | 106±0.4μs           |    0.99 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 248±2μs              | 249±1μs             |    1    | import_iris.Iris.time_analysis__interpolation                                               |
|          | 192±3μs              | 192±2μs             |    1    | import_iris.Iris.time_analysis__regrid                                                      |
|          | 110±1μs              | 111±0.9μs           |    1    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 135±3μs              | 138±0.6μs           |    1.02 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 326±4μs              | 328±3μs             |    1.01 | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.9±2μs             | 91.8±0.2μs          |    1    | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 213±2μs              | 212±3μs             |    0.99 | import_iris.Iris.time_analysis_maths                                                        |
|          | 95.3±0.2μs           | 94.8±0.9μs          |    0.99 | import_iris.Iris.time_analysis_stats                                                        |
|          | 172±1μs              | 172±1μs             |    1    | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 308±4μs              | 312±7μs             |    1.01 | import_iris.Iris.time_aux_factory                                                           |
|          | 80.5±0.7μs           | 80.3±0.6μs          |    1    | import_iris.Iris.time_common                                                                |
|          | 159±2μs              | 160±2μs             |    1    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.37±0.01ms          | 1.37±0.01ms         |    1    | import_iris.Iris.time_common_metadata                                                       |
|          | 168±3μs              | 167±1μs             |    1    | import_iris.Iris.time_common_mixin                                                          |
|          | 1.17±0ms             | 1.19±0.04ms         |    1.01 | import_iris.Iris.time_common_resolve                                                        |
|          | 198±0.9μs            | 201±50μs            |    1.02 | import_iris.Iris.time_config                                                                |
|          | 126±6μs              | 127±0.6μs           |    1.01 | import_iris.Iris.time_coord_categorisation                                                  |
|          | 377±6μs              | 384±3μs             |    1.02 | import_iris.Iris.time_coord_systems                                                         |
|          | 767±5μs              | 765±3μs             |    1    | import_iris.Iris.time_coords                                                                |
|          | 646±5μs              | 649±5μs             |    1    | import_iris.Iris.time_cube                                                                  |
|          | 235±4μs              | 236±3μs             |    1    | import_iris.Iris.time_exceptions                                                            |
|          | 73.8±0.8μs           | 74.1±0.6μs          |    1.01 | import_iris.Iris.time_experimental                                                          |
|          | 178±1μs              | 177±1μs             |    0.99 | import_iris.Iris.time_fileformats                                                           |
|          | 251±2μs              | 256±2μs             |    1.02 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.55±0.02ms          | 2.54±0.02ms         |    0.99 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 75.9±0.3μs           | 75.7±0.5μs          |    1    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 114±1μs              | 113±0.6μs           |    0.99 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 428±5μs              | 427±10μs            |    1    | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.78±0.1ms           | 4.76±0.02ms         |    1    | import_iris.Iris.time_fileformats_dot                                                       |
|          | 72.7±1μs             | 71.6±0.5μs          |    0.99 | import_iris.Iris.time_fileformats_name                                                      |
|          | 255±4μs              | 252±1μs             |    0.99 | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 114±0.7μs            | 113±0.9μs           |    0.99 | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 121±1μs              | 120±0.7μs           |    1    | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 216±5μs              | 209±2μs             |    0.97 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 797±3μs              | 805±10μs            |    1.01 | import_iris.Iris.time_fileformats_pp                                                        |
|          | 179±4μs              | 180±2μs             |    1.01 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 135±1μs              | 132±2μs             |    0.98 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 545±4μs              | 544±2μs             |    1    | import_iris.Iris.time_fileformats_rules                                                     |
|          | 221±2μs              | 221±0.6μs           |    1    | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.2±0.9μs           | 79.1±1μs            |    0.99 | import_iris.Iris.time_fileformats_um                                                        |
|          | 155±2μs              | 158±0.9μs           |    1.02 | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 138±2μs              | 138±0.8μs           |    1    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 73.0±1μs             | 72.1±2μs            |    0.99 | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 78.7±0.9μs           | 78.7±0.5μs          |    1    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 948±7μs              | 944±4μs             |    1    | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 137±2μs              | 137±2μs             |    1    | import_iris.Iris.time_io                                                                    |
|          | 174±1μs              | 174±0.7μs           |    1    | import_iris.Iris.time_io_format_picker                                                      |
|          | 207±3μs              | 210±3μs             |    1.02 | import_iris.Iris.time_iris                                                                  |
|          | 125±1μs              | 125±1μs             |    1    | import_iris.Iris.time_iterate                                                               |
|          | 8.15±0.2ms           | 8.24±0.04ms         |    1.01 | import_iris.Iris.time_palette                                                               |
|          | 1.75±0.01ms          | 1.75±0.01ms         |    1    | import_iris.Iris.time_plot                                                                  |
|          | 102±2μs              | 102±0.2μs           |    1    | import_iris.Iris.time_quickplot                                                             |
|          | 2.13±0.03ms          | 2.18±0.01ms         |    1.03 | import_iris.Iris.time_std_names                                                             |
|          | 1.82±0.01ms          | 1.83±0.02ms         |    1.01 | import_iris.Iris.time_symbols                                                               |
|          | 281±9ms              | 272±1ms             |    0.97 | import_iris.Iris.time_tests                                                                 |
|          | 249±2μs              | 250±2μs             |    1    | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.03±0.04ms          | 4.97±0.04ms         |    0.99 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 117±3μs              | 116±0.5μs           |    1    | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.67±0.01ms          | 2.68±0.01ms         |    1    | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.28±0.02ms          | 1.29±0.01ms         |    1    | import_iris.Iris.time_third_party_numpy                                                     |
|          | 167±3μs              | 166±4μs             |    0.99 | import_iris.Iris.time_third_party_scipy                                                     |
|          | 97.5±1μs             | 98.1±1μs            |    1.01 | import_iris.Iris.time_time                                                                  |
|          | 337±7μs              | 340±2μs             |    1.01 | import_iris.Iris.time_util                                                                  |
|          | 69.5±0.7μs           | 69.9±0.8μs          |    1.01 | iterate.IZip.time_izip                                                                      |
|          | 10.2±0.1ms           | 10.3±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 15.2±0.5ms           | 14.9±0.3ms          |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 10.1±0.04ms          | 10.2±0.2ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 10.1±0.1ms           | 10.2±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 12.9±0.2ms           | 12.8±0.2ms          |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 10.1±0.2ms           | 10.2±0.04ms         |    1.02 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.59±0.02s           | 1.59±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 11.7±0.7ms           | 11.7±0.1ms          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.59±0.02s           | 1.60±0.01s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.60±0.02s           | 1.59±0.02s          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 11.8±0.2ms           | 11.8±0.1ms          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.61±0.01s           | 1.59±0.01s          |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.24±0.04ms          | 5.27±0.08ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 11.6±0.2ms           | 11.4±0.08ms         |    0.99 | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.16±0.02ms          | 5.25±0.09ms         |    1.02 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.19±0.09ms          | 5.25±0.02ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 11.4±0.2ms           | 11.5±0.2ms          |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.22±0.04ms          | 5.27±0.06ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 23.5±1ms             | 22.2±1ms            |    0.95 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 19.2±0.4ms           | 19.0±0.2ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 11.9±1ms             | 11.7±0.7ms          |    0.98 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 27.1±0.8ms           | 26.7±0.7ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 68.8±0.6ms           | 68.3±0.7ms          |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 26.8±0.4ms           | 25.9±0.6ms          |    0.97 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 546±10ms             | 547±10ms            |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 2.72±0.1ms           | 2.65±0.1ms          |    0.97 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 552±8ms              | 555±9ms             |    1.01 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 557±7ms              | 567±10ms            |    1.02 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 2.79±0.2ms           | 2.68±0.07ms         |    0.96 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 558±8ms              | 559±10ms            |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.68±0.05ms          | 1.67±0.09ms         |    1    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 2.67±0.1ms           | 2.59±0.1ms          |    0.97 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.58±0.05ms          | 1.63±0.06ms         |    1.03 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.67±0.05ms          | 1.70±0.04ms         |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 2.84±0.06ms          | 2.68±0.1ms          |    0.94 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.71±0.05ms          | 1.69±0.07ms         |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 351±3ms              | 349±4ms             |    0.99 | load.ManyCubes.time_many_cube_load                                                          |
|          | 85.9±2ms             | 85.2±0.5ms          |    0.99 | load.ManyVars.time_many_var_load                                                            |
|          | 10.2±0.3ms           | 10.3±0.2ms          |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.3±0.2ms           | 10.6±0.2ms          |    1.03 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.59±0.01s           | 1.61±0.01s          |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.62±0.04s           | 1.62±0.01s          |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.22±0.04ms          | 5.32±0.1ms          |    1.02 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.27±0.1ms           | 5.30±0.01ms         |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.73±0.6ms           | 9.49±0.04ms         |    0.98 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 6.55±0.3ms           | 6.22±0.1ms          |    0.95 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.58±0.03s           | 1.59±0.03s          |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 582±9ms              | 582±6ms             |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.58±0.1ms           | 4.47±0.08ms         |    0.98 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.48±0.2ms           | 4.46±0.05ms         |    1    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 176±3ms              | 177±3ms             |    1    | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 15.0±0.6ms           | 14.9±0.3ms          |    0.99 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 177±1ms              | 178±3ms             |    1.01 | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 33.7±0.9ms           | 34.3±0.7ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 14.5±0.5ms           | 14.8±0.2ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 33.3±1ms             | 35.3±1ms            |    1.06 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 13.4±0.7ms           | 13.6±0.3ms          |    1.02 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 48.8±1ms             | 48.0±1ms            |    0.98 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 8.73±0.4ms           | 8.83±0.1ms          |    1.01 | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 15.8±1ms             | 16.0±0.6ms          |    1.01 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 13.5±0.3ms           | 13.5±0.2ms          |    1    | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 15.4±0.8ms           | 15.2±0.5ms          |    0.99 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 8.85±0.3ms           | 8.84±0.2ms          |    1    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 11.6±0.4ms           | 11.4±0.3ms          |    0.98 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 14.9±0.3ms           | 14.6±0.3ms          |    0.98 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 58.5±0.9ms           | 58.5±0.6ms          |    1    | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 14.9±0.3ms           | 14.6±0.2ms          |    0.98 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 16.8±0.4ms           | 16.7±0.2ms          |    0.99 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 2.56±0.3ms           | 2.62±0.1ms          |    1.02 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 3.70±0.4ms           | 3.52±0.3ms          |    0.95 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 35.2±4ms             | 34.3±2ms            |    0.98 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 787±20ms             | 779±3ms             |    0.99 | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 1.40±0.02s           | 1.38±0.02s          |    0.99 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 443±3ms              | 445±9ms             |    1    | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 1.89±0G              | 1.89±0G             |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.3M             | 109±0.3M            |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 30.9±1ms             | 30.4±0.9ms          |    0.98 | merge_concat.Merge.time_merge                                                               |
|          | 84.1±0.02M           | 84±0.02M            |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 339±5ns              | 340±10ns            |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 193±0.7ms            | 195±0.3ms           |    1.01 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 651±1k               | 651±1k              |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M              | 60.1±0M             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 17.9±0.1ms           | 17.9±0.4ms          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 20.1±0.3ms           | 20.5±0.4ms          |    1.02 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 1.13±0M              | 1.14±0M             |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 13±0M                | 13±0M               |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 108±3ms              | 106±2ms             |    0.99 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 583±7ms              | 587±8ms             |    1.01 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.29±0.01M           | 1.31±0.03M          |    1.02 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.3±0.02M           | 96.3±0.02M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 68.4±2ms             | 67.7±2ms            |    0.99 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 535±3ms              | 534±5ms             |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.19±0.01M           | 1.19±0.01M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.01M           | 96.2±0.01M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.70±0.3ms           | 6.74±0.04ms         |    1.01 | plot.AuxSort.time_aux_sort                                                                  |
|          | 73.4±3ms             | 77.8±4ms            |    1.06 | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 99.5±0.7ms           | 99.4±0.5ms          |    1    | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 49.3±1ms             | 49.3±1ms            |    1    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.06M            | 106±0.05M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.02M            | 147±0.02M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.44±0.3ms           | 4.35±0.03ms         |    0.98 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 72.2±5ms             | 72.5±2ms            |    1    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 42.9±1ms             | 43.0±0.5ms          |    1    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 480±10ms             | 478±3ms             |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 85.0±1ns             | 84.7±10ns           |    1    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 54.1±4ms             | 54.5±1ms            |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 85.7±0.6ns           | 85.7±10ns           |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 420±7ms              | 421±4ms             |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 30.6±0.1k            | 30.6±0.2k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.6±0.1M             | 1.71±0.1M           |    1.07 | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 30.6±0.1k            | 30.6±0.1k           |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 190±20M              | 208±20M             |    1.09 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 42.3±0.8ms           | 41.3±0.5ms          |    0.98 | stats.PearsonR.time_lazy                                                                    |
|          | 9.10±0.4ms           | 9.06±0.1ms          |    1    | stats.PearsonR.time_real                                                                    |
|          | 25.5±1M              | 23.1±1M             |    0.9  | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M           | 18.4±0.01M          |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 20.4±0.4ms           | 20.5±0.3ms          |    1.01 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 66.0±1ms             | 65.9±0.3ms          |    1    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.02M           | 17.6±0.02M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.01M           | 12.1±0.01M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 13545630445

@bouweandela bouweandela marked this pull request as ready for review February 26, 2025 15:20
This was referenced Feb 28, 2025
Closed
Merged
pp-mo
pp-mo approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should really have merged this one some time ago,
but I sort-of forgot it was not already done !

@pp-mo pp-mo merged commit 9fede7c into SciTools:main Mar 6, 2025
21 checks passed
@bouweandela bouweandela deleted the fix-non-lazy-benchmarks branch March 6, 2025 16:16
@trexfeathers trexfeathers mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

@trexfeathers trexfeathers Awaiting requested review from trexfeathers

Assignees
No one assigned
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
🚴 Peloton
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouweandela @pp-mo