Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Shellbar Examples and Size added #3513

Merged
merged 4 commits into from
Oct 1, 2020
Merged

fix: Shellbar Examples and Size added #3513

merged 4 commits into from
Oct 1, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

part of #3420

Please provide a brief summary of this pull request.

This PR contains:
Lib:

  • Added size property for shellbar
  • Fixed Menu with icons usage
  • Removed unused code from *.scss regarding fd-shellbar-side-nav-control

From Documentation:

  • Changed example of collapsible shellbar - Added description about size
  • Fixed example of visual in shellbar with side nav

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski added core Core library specific issues 0.22.0 labels Sep 30, 2020
@JKMarkowski JKMarkowski added this to the Sprint 47 - Bali milestone Sep 30, 2020
@JKMarkowski JKMarkowski requested a review from a team September 30, 2020 12:08
@JKMarkowski JKMarkowski self-assigned this Sep 30, 2020
@netlify
Copy link

netlify bot commented Sep 30, 2020 •
edited
Loading

Deploy preview for fundamental-ngx ready!

Built with commit c251370

https://deploy-preview-3513--fundamental-ngx.netlify.app

@katekozlowska katekozlowska self-requested a review September 30, 2020 13:26
@JKMarkowski JKMarkowski mentioned this pull request Sep 30, 2020
Closed
@JKMarkowski JKMarkowski merged commit ea576f2 into master Oct 1, 2020
@JKMarkowski JKMarkowski deleted the fix/shellbar-examples branch October 1, 2020 12:10
AntonOlkhovskyi pushed a commit to AntonOlkhovskyi/fundamental-ngx that referenced this pull request Nov 16, 2020
@JKMarkowski
fix: Shellbar Examples and Size added (SAP#3513)
cf86be2 
* fix: Add shellbar size, fix examples

* add docs style changes for shellbar nav

* remove redundant test

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katekozlowska katekozlowska katekozlowska approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@JKMarkowski JKMarkowski

Labels
core Core library specific issues Defect Hunting
Projects
None yet
Milestone
Sprint 47 - Bali
Development

Successfully merging this pull request may close these issues.
3 participants
@JKMarkowski @katekozlowska @InnaAtanasova