Defect Hunting Fundamental NGX 0.22 [2]

[salarenko]

Defect Hunting before v0.22.0 release.

[JKMarkowski]

FIREFOX

• Notifications - Need to bring old styling - Inna PR open

• Header Github icon not centered - Inna PR open
  

• Overflow breadcrump - Color + cursor is not pointer fix: Breadcrumb expand collapsed items styling  #3462
  

• Checkbox/Radio button - remove outdated alert - Deno - docs: remove message strip info message from radio and checkbox #3431
  

• Dialog - Need to bting changes from this pr fix: Update Dialog title styling #3463
  

• Info label icon is not centered - Inna: I couldn't find the issue. I tested all browser.
  

• Object status - __text wrapper exist even if there is no text - Inna PR
  

• Combobox - No way to escape focus by tab, after opening combobx fix: Combobox navigate with tab #3464
  

• Popover example site - missing Avatar styling Tested - cannot reproduce
  

• Action Bar - Need to bring changes from this pr - Inna PR
  

• Checkbox in multi input - When focused on checkbox and space key is pressed, the checkbox is triggered twice - fix: Firefox double triggered checkbox #3506
  

• Compact multi input - height is same as for cozy (should be 32px)
  

Inna: I checked FF and Chrome, both have 32px height:

• Popover placement example - Inna PR
  

• Shellbar - Avatar - Inna PR
  

• Side Navigation - expand icon doesn't show - https://github.com/SAP/fundamental-ngx/pull/3510/files
  

• Shellbar - Missing action hide behaviour, which was introduced in this PR - Shoudl be added new example with --s size - fix: Shellbar Examples and Size added #3513

• Table - Customizable Columns Dialog - list doesn't have proper [selection] mode - docs: Update Table example #3505
  

• Table - Column sorting/filtering - popover filter doesn't work and can't be focused by click - Currently Meanu cannot be used with items like inputs
  

[katekozlowska]

CHROME

• Popover placement: Inna PR
  

• Tokens are not centered - Inna: this issue is related to styles. I opened an issue there Token in compact mode is not vertically aligned fundamental-styles#1731
  

• Avatar on shellbar is broken - Inna PR
  

• Table - adding new item: close button is missaligned - not reproducible after Buttons PR was merged
  

• Carrets (arrows) are not centered (see seconds example) - not reproducible after Buttons PR was merged
  

[salarenko]

• Floating Bar Footer example is broken - IE11 - Inna PR
  

• composedPath is not supported in IE11 (Popover) fix: Popover shadow dom for IE11 #3511

• attachShadow is not supported in IE11, breaking whole documentation page (Popover) fix: Popover shadow dom for IE11 #3511

• File Uploader placeholder is cleared out when file input is focused - IE11 - Inna: my Google search showed that this is the expected behaviour in IE11. Check https://social.msdn.microsoft.com/Forums/en-US/169513d0-d1f2-437a-9118-783dc7e19d66/in-ie11-browser-placeholder-text-for-any-input-text-disappears-on-focus?forum=iewebdevelopment
  

• Shellbar Menu button icon - IE11 - Inna PR
  

• Empty column in table example - Cross browser - Inna PR
  

• Select animation making people angry - Cross Browser
  

• Combobox Custom Item Template should be updated to use list item markup to provide proper styling. docs: Combobox custom template #3512

• Layout Grid is missing styles - Cross browser- Michal PR
  

[katekozlowska]

Several issues reported under FIrefox are also applicable to Chrome, please check fixes under both browsers.

[stefanoScalzo]

Table toolbar issues

[InnaAtanasova]

Table toolbar issues

@stefanoScalzo
If you meant buttons issues in the table, they've been fixed with the Buttons PR. Here's how it's in master now:

If you meant other issues, please specify

[InnaAtanasova]

All issues have been addressed and the PRs have been merged. Awesome job everyone!