Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IrisZo: Better Handle Cases when the Center of the Ellipsoid is In-Collision #22737

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cohnt
Copy link
Contributor

@cohnt cohnt commented Mar 11, 2025

Closes #22714

Note that we make two changes here:

  1. We throw an error if the user provides a seed point that is in-collision (or violates one of the additional constraints the user has provided)
  2. If after the first iteration, the center of the ellipsoid moves to a configuration that's in-collision, we return the polytope from the previous iteration, and warn the user that this has occurred.

This change is Reviewable

@cohnt cohnt added status: do not review release notes: fix This pull request contains fixes (no new features) labels Mar 11, 2025
…er is in collision (or violates one of the additional user-provided constraints).
@cohnt cohnt force-pushed the iriszo-ellipsoid-center branch from bfacb6f to 56344c4 Compare March 11, 2025 18:59
Copy link
Contributor Author

@cohnt cohnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@wernerpe for feature review, please!

Reviewable status: 2 unresolved discussions, LGTM missing from assignee wernerpe, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)


-- commits line 1 at r1:
working.. will set final commit message later


planning/iris/iris_zo.cc line 675 at r1 (raw file):

      break;
    }
    if (!checker.CheckConfigCollisionFree(

A note to the eventual platform reviewer -- although we know this is possible in theory, we haven't been able to reproduce it in practice. So we'd like to include the solution, even though we don't yet have a test case that triggers this code path.

Note that besides the different triggering conditions, the logic is exactly the same as the case where we set options.max_iterations to 1.

Copy link
Contributor

@wernerpe wernerpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @cohnt)

@cohnt
Copy link
Contributor Author

cohnt commented Mar 11, 2025

+@rpoyner-tri for platform review, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features)
Projects
Status: TODO (IRIS and Convex Sets)
Development

Successfully merging this pull request may close these issues.

IrisZo Unintuitive Behavior when Ellipsoid Center is in Collision
3 participants