[workspace] Reduce global variable constructor spam from VTK #22726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drake's style guide forbids the use of global variable constructors and destructors. Merely loading a library should never execute any code (ditto for unloading / program shutdown). Code should bootstrap any necessary initialization the first time it runs; we mustn't let code that will never be run have effects elsewhere. This doesn't fix all of the global variables yet, but it does fix many of them.
jwnimmer-tri
added
priority: low
release notes: none
|
+@BetsyMcPhail for feature review or delegation, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drake's style guide forbids the use of global variable constructors and destructors. Merely loading a library should never execute any code (ditto for unloading / program shutdown). Code should bootstrap any necessary initialization the first time it runs; we mustn't let code that will never be run have effects elsewhere.
This doesn't fix all of the global variables yet, but it does fix many of them.
(Note that
*.ccsource files still have<iostream>. I have a separate work in progress that fixes<iostream>for all of our externals, but only in*.ccfiles. We need to evict iostream from header files before it can succeed.)This change is