Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Mesh/Convex to use non-uniform scales #22723

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SeanCurtis-TRI
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI commented Mar 7, 2025

This change is Reviewable

@SeanCurtis-TRI
Copy link
Contributor Author

Running against CI before decomposing into three PRs.

@SeanCurtis-TRI
Copy link
Contributor Author

Testing against Anzu - build 297.

 - testing apparently finished!

TODO:
 - bindings
 - Documentation (I'm not entirely sure what I had in mind here.)

Augment bindings and tests

TODO:
 - The API on proximity engine to lead out the MeshDistanceBoundary is
   causing problems. The build system is unhappy with trying to pull in the
   header file in various locations.
     - I need to resolve this.
     - I believe, simply, a different test API would be sufficient.
@SeanCurtis-TRI SeanCurtis-TRI force-pushed the PR_mesh_scale_as_vector branch from 752db4d to 69baffb Compare March 10, 2025 21:57
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day, @SeanCurtis-TRI . This PR does not yet have a reviewer assigned. Is it ready for review yet? If yes, then please assign a feature reviewer. If not, then please label it “status: do not review”.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @SeanCurtis-TRI)

@SeanCurtis-TRI
Copy link
Contributor Author

@rpoyner-tri I thought that marking it as a draft PR was sufficient to not get caught up in that net.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, it is not. I don't recall the reasons, but I think I offered a query patch in that line that was rejected.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @SeanCurtis-TRI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants