Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[multibody] MakeMobilizerForJoint() can now create Frames" #22688

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Mar 3, 2025

Reverts #22649. This is breaking end-user simulations:

RuntimeError: Model instance 'WorldModelInstance' already contains a frame named 'world_welds_to_base_link_world_F'. Frame names must be unique within a given model.

or

RuntimeError: Model instance 'manipuland_table' already contains a frame named 'origin_welds_to_origin_origin_F'. Frame names must be unique within a given model.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: high status: single reviewer ok https://drake.mit.edu/reviewable.html labels Mar 3, 2025
@jwnimmer-tri
Copy link
Collaborator Author

+@sherm1 for stamping, if there isn't a very quick fix.

@jwnimmer-tri jwnimmer-tri added the release notes: none This pull request should not be mentioned in the release notes label Mar 3, 2025
@sherm1
Copy link
Member

sherm1 commented Mar 3, 2025

Investigating now ...

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I have a hotfix in #22691 but don't currently have a way to reproduce the presenting problem so we'll revert for now.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sherm1(platform)

@jwnimmer-tri jwnimmer-tri merged commit 8d39970 into master Mar 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants