[doc] Add release notes v1.33.0 #21885
Conversation
SeanCurtis-TRI
added
the
release notes: none
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
a discussion (no related file):
Still need to:
- Remove extraneous TBD
- Update dates at the end of the week.
doc/_release-notes/v1.33.0.md line 53 at r1 (raw file):
<!-- <relnotes for geometry,multibody go here> --> * [feature] TBD Replace BodyIndex with LinkIndex alias ([#21811][_#21811])
@sherm1 I commented on the PR, but this is where it's relevant.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 53 at r1 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
@sherm1 I commented on the PR, but this is where it's relevant.
You're right that this change is entirely internal and shouldn't be mentioned here. My bad!
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.33.0.md line 53 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
You're right that this change is entirely internal and shouldn't be mentioned here. My bad!
Thanks
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 124 at r3 (raw file):
* `pydrake.multibody.MultibodyPlant.SetDefaultFreeBodyPose` with parameter X_WB ([#21808][_#21808]) * `pydrake.multibody.MultibodyPlant.SetFreeBodySpatialVelocity` with parameter V_WB ([#21808][_#21808])
#21807 deprecates CalcPairwiseIntersections and introduces a replacement ComputePairwiseIntersections with a different return signature. Not sure what message makes the most sense (and whether you also want to include it in "New features", or just in "Newly-deprecated APIs").
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.33.0.md line 124 at r3 (raw file):
Previously, cohnt (Thomas Cohn) wrote…
#21807 deprecates
CalcPairwiseIntersectionsand introduces a replacementComputePairwiseIntersectionswith a different return signature. Not sure what message makes the most sense (and whether you also want to include it in "New features", or just in "Newly-deprecated APIs").
Thanks for calling this out. I'll do a refresh on this branch tomorrow to pick up changes since Monday morning and that should get included. I'll leave this topic open to make sure I don't miss it.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.33.0.md line 124 at r3 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
Thanks for calling this out. I'll do a refresh on this branch tomorrow to pick up changes since Monday morning and that should get included. I'll leave this topic open to make sure I don't miss it.
Alrighty. Taken care of officially.
SeanCurtis-TRI
force-pushed
the
release_notes-v1.33.0
branch
from
80c7b13 to
50e0aa5
Compare
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 124 at r3 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
Alrighty. Taken care of officially.
Does drake::geometry::CalcPairwiseIntersections encompass the python bindings? (The corresponding bindings have also been deprecated.)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 5 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 14 at r5 (raw file):
* Changed return values for GraphOfConvexSets SolveShortestPath and SolveConvexRestriction functions to resolve inconsistencies ([#21833][_#21833]) * Changed return value of GraphOfConvexSets::GetSolution*() to return std::nullopt rather than NaN ([#21843][_#21843])
Neither 21833 nor 21843 are a breaking change, since the GraphOfConvexSets class is documented as @experimental.
It might be an important change that merits a stronger-than-usual highlight somewhere in the notes, but we should do ourselves the disservice of claiming that we broke the rules in cases where we didn't.
doc/_release-notes/v1.33.0.md line 70 at r5 (raw file):
New features * Add PathEnergyCost to GCSTrajectoryOptimization ([#21810][_#21810])
nit The class name is camel GcsTrajectoryOptimization not scream GCSTrajectoryOptimization. (Ditto throughout.)
doc/_release-notes/v1.33.0.md line 109 at r5 (raw file):
<!-- <relnotes for cmake,doc,setup,third_party,tools go here> --> * [fix] TBD [third_party,workspace] [workspace] Upgrade bazelisk to latest release v1.21.0 ([#21888][_#21888])
nit I like how 21888 is listed beside 21884 down below. That means we can delete this line.
There was a problem hiding this comment.
Reviewable status: 5 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 14 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Neither 21833 nor 21843 are a breaking change, since the
GraphOfConvexSetsclass is documented as@experimental.It might be an important change that merits a stronger-than-usual highlight somewhere in the notes, but we should do ourselves the disservice of claiming that we broke the rules in cases where we didn't.
*shouldn't
There was a problem hiding this comment.
Reviewable status: 6 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 15 at r5 (raw file):
* Changed return values for GraphOfConvexSets SolveShortestPath and SolveConvexRestriction functions to resolve inconsistencies ([#21833][_#21833]) * Changed return value of GraphOfConvexSets::GetSolution*() to return std::nullopt rather than NaN ([#21843][_#21843]) * drake::multibody::FrameBase class removed ([#21853][_#21853])
Blocking the release until #21891 is merged.
There was a problem hiding this comment.
Reviewable status: 4 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.33.0.md line 124 at r3 (raw file):
Previously, cohnt (Thomas Cohn) wrote…
Does
drake::geometry::CalcPairwiseIntersectionsencompass the python bindings? (The corresponding bindings have also been deprecated.)
A fine point. Added.
doc/_release-notes/v1.33.0.md line 14 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
*shouldn't
@RussTedrake I've moved it to announcements. Should we simply pull them?
doc/_release-notes/v1.33.0.md line 70 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit The class name is camel
GcsTrajectoryOptimizationnot screamGCSTrajectoryOptimization. (Ditto throughout.)
I only found the one.
doc/_release-notes/v1.33.0.md line 109 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit I like how 21888 is listed beside 21884 down below. That means we can delete this line.
Oops. That was simply an oversight.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 70 at r5 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
I only found the one.
Great. (I hadn't looked.)
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 15 at r5 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Blocking the release until #21891 is merged.
This has merged to master now, to feel free to close this thread once you merge that in here -- at which point, this bullet should relocate from "breaking changes" down into "newly deprecated".
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: 4 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
doc/_release-notes/v1.33.0.md line 67 at r7 (raw file):
* Update APIs on MultibodyPlant for working with free bodies to more clearly reflect current implementation ([#21808][_#21808]) * Fix Drake Model Directive default_free_body_pose vs offset frames ([#21765][_#21765]) * When .mtl files are missing, render colors instead ([#21889][_#21889])
nit This line should probably mention meshcat, for clarity?
doc/_release-notes/v1.33.0.md line 127 at r7 (raw file):
* Upgrade buildifier to latest release v7.3.1 ([#21887][_#21887]) * Upgrade clp_internal to latest release releases/1.17.10 ([#21887][_#21887]) * Upgrade coinutils_internal to latest release releases/2.11.12 ([#21887][_#21887])
nit Please strip chaff off of the version numbers. (Ideally we would teach the automation tool to handle this for us, but we haven't done that yet.)
Suggestion:
* Upgrade clp_internal to latest release 1.17.10 ([#21887][_#21887])
* Upgrade coinutils_internal to latest release 2.11.12 ([#21887][_#21887])doc/_release-notes/v1.33.0.md line 132 at r7 (raw file):
* Upgrade dm_control_internal to latest release 1.0.22 ([#21887][_#21887]) * Upgrade googlebenchmark to latest release v1.9.0 ([#21887][_#21887]) * Upgrade gz_math_internal to latest release gz-math7_7.5.1 ([#21887][_#21887])
nit Please strip chaff off of the version number.
Suggestion:
7.5.1
There was a problem hiding this comment.
Last call. I've updated for this morning's clean CI and will be cutting a release today.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
a discussion (no related file):
nit Reminder that this PR also should change doc/_pages/from_binary.md as you proceed through the playbook, before merging.
doc/_release-notes/v1.33.0.md line 108 at r9 (raw file):
* Add Python bindings for drake::geometry::optimization::ConvexHull ([#21849][_#21849]) * Bind Joint.kTypeName constants ([#21896][_#21896])
BTW Not a big deal, but if you like these two bullets could use a more uniform phrasing. "Bind (thing)" is generally my favorite spelling.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.33.0.md line 108 at r9 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
BTW Not a big deal, but if you like these two bullets could use a more uniform phrasing. "Bind (thing)" is generally my favorite spelling.
I had the same thought but ended up on "meh". I'll get around to it once I'm done my current pass on the MeshSource stuff.
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r9, all commit messages.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
This reverts commit 140c8f9.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit Reminder that this PR also should change
doc/_pages/from_binary.mdas you proceed through the playbook, before merging.
Updated
a discussion (no related file):
Blocking. Waiting on successful wheel builds.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r10, all commit messages.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @SeanCurtis-TRI)
a discussion (no related file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
Blocking. Waiting on successful wheel builds.
Wheels succsesfully built.
SeanCurtis-TRI
added
the
status: squashing now
There was a problem hiding this comment.
+(status: squashing now)
Reviewable status:
complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)
This change is