Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request any changes to GOVERNANCE tag all committers #6749

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Request any changes to GOVERNANCE tag all committers #6749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b196f36
Request any changes to GOVERNANCE tag all committers
MichaelChirico Jan 21, 2025
61fae3e
add edit notes
MichaelChirico Jan 21, 2025
c5c37cb
Update in CODEOWNERS
MichaelChirico Jan 21, 2025
f8d2cb3
reword after CODEOWNERS change
MichaelChirico Jan 21, 2025
1e36c5c
grammar
MichaelChirico Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
# docs
/man/openmp-utils.Rd @Anirban166
/Seal_of_Approval.md @tdhock
/GOVERNANCE.md: @Rdatatable/committers

# GLCI
.gitlab-ci.yml @jangorecki @ben-schwen
7 changes: 5 additions & 2 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ A pull request can be merged by any committer, if there is one approving review,

## Changing this GOVERNANCE.md document

There is no special process for changing this document (submit a PR
and ask for review).
There is no special process for changing this document. Submit a PR and ask for review; the group `@Rdatatable/committers` will automatically be assigned to ensure all current Committers are aware of the change.

Please also make a note in the change log under [`# Governance history`](#governance-history)

# Code of conduct

Expand Down Expand Up @@ -123,6 +124,8 @@ data.table Version line in DESCRIPTION typically has the following meanings

# Governance history

Jan 2025: clarify that edits to governance should notify all committers.

Feb 2024: change team name/link maintainers to committers, to be consistent with role defined in governance.

Nov-Dec 2023: initial version drafted by Toby Dylan Hocking and
Expand Down
Loading