Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request any changes to GOVERNANCE tag all committers #6749

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

MichaelChirico
Copy link
Member

cc @Rdatatable/committers.

I think any change for GOVERNANCE should at least directly ping all Committers.

@MichaelChirico MichaelChirico added the governance Project governance label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (7445df7) to head (1e36c5c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6749   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14641    14641           
=======================================
  Hits        14440    14440           
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdhock
Copy link
Member

tdhock commented Jan 21, 2025

great idea!

@tdhock
Copy link
Member

tdhock commented Jan 21, 2025

maybe add @rdatatable/committers to GOVERNANCE.md in CODEOWNERS?

@MichaelChirico
Copy link
Member Author

Great idea! Does that mean Committers will always be the first "suggested reviewer", or that they'll definitely always be notified...

@MichaelChirico
Copy link
Member Author

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.

Another question is whether that group has write permissions? not sure how to tell:

When the code owner is a team, that team must be visible and it must have write permissions

@MichaelChirico MichaelChirico merged commit f048658 into master Jan 22, 2025
10 checks passed
@MichaelChirico MichaelChirico deleted the governance-committers-tag branch January 22, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance Project governance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants