Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trip] Support more parameter combinations of fixed start/end when requesting roundtrips #3675

Conversation

chaupow
Copy link
Member

@chaupow chaupow commented Feb 8, 2017

Issue

This PR implements all supported parameter combinations tagged as Shouldn't be too hard to extend to

Roundtrip NoRoundtrip
Fixed Start&End (FSE) Shouldn't be too hard to extend to Already Implemented
Fixed Start (FS) Shouldn't be too hard to extend to Won't do this for now
Fixed End (FE) Shouldn't be too hard to extend to Won't do this for now
Nothing fixed Already Implemented Won't do this for now

Tasklist

  • update relevant Wiki pages
  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for comments

Requirements / Relations

based on #3408
based on #3675

@chaupow chaupow changed the base branch from fixed-start-and-end-trip to fix/change-source-destination-trip-parameter February 8, 2017 14:19
@@ -51,6 +51,64 @@ Feature: Basic trip planning
| waypoints | trips |
| a,b,c,d,e,f,g,h,i,j,k,l | alkjihgfedcba |

Scenario: Testbot - Roundtrip FS waypoints >10
Given the query options
| source | first |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these to the "When I plan a trip I should get" portion of the test

@ghoshkaj ghoshkaj merged commit 9330a5b into fix/change-source-destination-trip-parameter Feb 8, 2017
@ghoshkaj ghoshkaj deleted the feature/trip_support_more_parameter_combinations branch February 8, 2017 16:43
ghoshkaj pushed a commit that referenced this pull request Feb 8, 2017
…questing roundtrips (#3675)

* support all combinations of fixed start/end when requesting roundtrips
ghoshkaj pushed a commit that referenced this pull request Feb 8, 2017
…in (#3674)

* [Trip] Support more parameter combinations of fixed start/end when requesting roundtrips (#3675)
ghoshkaj pushed a commit that referenced this pull request Feb 10, 2017
…in (#3674)

* [Trip] Support more parameter combinations of fixed start/end when requesting roundtrips (#3675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants