Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trip] Change source and destination parameters for the trip plugin #3674

Merged
merged 2 commits into from
Feb 8, 2017
Merged

[Trip] Change source and destination parameters for the trip plugin #3674

merged 2 commits into from
Feb 8, 2017

Conversation

chaupow
Copy link
Member

@chaupow chaupow commented Feb 7, 2017 •
edited
Loading

Issue

starts implementing
https://github.com/mapbox/directions/issues/471

Tasklist

  • clean up unit tests
  • clean up cucumber tests
  • update relevant Wiki pages
  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for comments

edit: sorry features/testbot/trip.feature is a bite messed up in split view 😞
edit2: also, i should start doing multiple commits

  • "real" changes happening in
    • src/engine/plugins/trip.cpp
    • include/engine/api/trip_parameters.hpp
    • include/server/api/trip_parameter_grammar.hpp
  • adapting test cases in all other touched files

@chaupow chaupow force-pushed the fix/change-source-destination-trip-parameter branch 4 times, most recently from 70c55d0 to a6a9d90 Compare February 8, 2017 11:07
@chaupow chaupow requested a review from ghoshkaj February 8, 2017 12:15
@chaupow chaupow changed the title Change source and destination parameters for the trip plugin [Trip] Change source and destination parameters for the trip plugin Feb 8, 2017
@chaupow
[Trip] Support more parameter combinations of fixed start/end when re…
7ba551c 
…questing roundtrips (#3675)

* support all combinations of fixed start/end when requesting roundtrips
@ghoshkaj ghoshkaj force-pushed the fixed-start-and-end-trip branch from 50c96e0 to ef27628 Compare February 8, 2017 16:50
@ghoshkaj ghoshkaj force-pushed the fix/change-source-destination-trip-parameter branch from 9330a5b to 7ba551c Compare February 8, 2017 16:51
ghoshkaj
ghoshkaj reviewed Feb 8, 2017
View reviewed changes
Copy link
Member

@ghoshkaj ghoshkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated some wording on the docs but it all seems good to me. :) Merging when the master problem gets solved.

@ghoshkaj ghoshkaj force-pushed the fixed-start-and-end-trip branch from ef27628 to 213423e Compare February 8, 2017 17:58
@chaupow chaupow force-pushed the fix/change-source-destination-trip-parameter branch from 0f60f29 to 951b0f0 Compare February 8, 2017 18:11
@ghoshkaj ghoshkaj merged commit 4698ebd into fixed-start-and-end-trip Feb 8, 2017
@ghoshkaj ghoshkaj deleted the fix/change-source-destination-trip-parameter branch February 8, 2017 18:12
@ghoshkaj ghoshkaj removed the Review label Feb 8, 2017
ghoshkaj pushed a commit that referenced this pull request Feb 10, 2017
@chaupow
[Trip] Change source and destination parameters for the trip plug…
b4ca2cb 
…in (#3674)

* [Trip] Support more parameter combinations of fixed start/end when requesting roundtrips (#3675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoshkaj ghoshkaj ghoshkaj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaupow @ghoshkaj