Portable HTML: svg embedding #2430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a template for embedding a latex-image- or prefigure-generated svg directly in the html. The template is called based on the
$b-portable-htmlvariable (note, since #2429 is not yet merged, a commented line at 5911 ofpretext-html.xslallows for testing; this and the previous line should be removed prior to merging).I am not sure if I have the namespace stuff right. I was able to copy the
xmlns:..."attributes" of the original svg, but had to hard code in thexmlns="..../svg"directly (which might be bad, I have no idea). See lines 6158-6159.Finally, a small tweak to the css to put a white background behind svg's like images get, needed for dark mode.
I have NOT refrained from copying the generated latex-image folder to output; that would require testing on a pubvar, and I need to think about the right way to do this with the very recent pub-var-report that got moved in. So it's on my radar.