Portable html: the css and javascript parts #2429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appears a |
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new publication variable at
/publication/html/platform/@portable, which when set to "yes" will result in the HTML using a CDN for all css and javascript, and not copy those files to the output.This is set up to allow the CLI to set a string-param for
cli.version, which will be added to the URL for the CDN (since we will keep the versions of the css and javascript versioned identically to the cli).The documentation and schema for the publication file had outdated information about
platform: they said that@platformwas an attribute of/publication/html, rather thanplatformbeing a child element of/publication/html. That is fixed in the guide and publication schema, adjacent to the new@portableattribute.Happy to rename things as needed, but this does seem functional now.