Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] fp16/bf16 for multinomial op #9550

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Dec 3, 2024

PR types

New features

PR changes

Others

Description

在较早的飞桨XPU版本中,multinomial算子不支持float16数据类型,所以在这个PR #8787 中进行了一个特殊处理,进行了一次数据类型转换。

现在飞桨的develop分支下,XPU版本中,已经支持了float16和bfloat16数据类型,见这两个PR PaddlePaddle/Paddle#69767PaddlePaddle/Paddle#69898 ,因此在组网代码里面不再需要这个多出来的cast操作了。

Copy link

paddle-bot bot commented Dec 3, 2024

Thanks for your contribution!

@paddle-bot paddle-bot bot added the XPU label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.00%. Comparing base (2c1387f) to head (7a08a16).
Report is 149 commits behind head on develop.

❌ Your project check has failed because the head coverage (53.00%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9550      +/-   ##
===========================================
+ Coverage    52.85%   53.00%   +0.14%     
===========================================
  Files          700      701       +1     
  Lines       110418   111140     +722     
===========================================
+ Hits         58359    58907     +548     
- Misses       52059    52233     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houj04 houj04 changed the title [XPU] fp16 for multinomial op [XPU] fp16/bf16 for multinomial op Dec 3, 2024
Copy link

github-actions bot commented Feb 3, 2025

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added the stale label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant