[XPU] use allgather and fp32 multinomial for XPU #8787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8787 +/- ##
===========================================
+ Coverage 55.44% 55.49% +0.05%
===========================================
Files 626 626
Lines 98064 98069 +5
===========================================
+ Hits 54367 54427 +60
+ Misses 43697 43642 -55 ☔ View full report in Codecov by Sentry. |
wawltor
reviewed
Jul 22, 2024
| @@ -42,7 +42,7 @@ | |||
| load_state_dict, | |||
| ) | |||
| from ...transformers.utils import get_checkpoint_shard_files, weight_name_suffix | |||
| from ...utils.distributed import distributed_gather | |||
| from ...utils.distributed import distributed_allgather, distributed_gather | |||
| from ...utils.env import LORA_WEIGHTS_NAME, SAFE_PEFT_WEIGHTS_INDEX_NAME | |||
There was a problem hiding this comment.
在XPU和GPU的接口里面可以直接同时import distributed_allgather 和 distributed_gather 吗
There was a problem hiding this comment.
参考代码是：#8697
改这个的原因是，XPU目前不支持gather。
gather和allgather对于rank0是一样的，对于非rank0不同。但是代码逻辑中有is_dst的控制，非rank0的反正都会扔掉不要，所以就直接替换了。
FeixLiu
pushed a commit
to FeixLiu/PaddleNLP
that referenced
this pull request
Jul 26, 2024
FeixLiu
pushed a commit
to FeixLiu/PaddleNLP
that referenced
this pull request
Jul 26, 2024
gongel
pushed a commit
that referenced
this pull request
Jul 31, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
Description
针对XPU的特性修改两处：
multinomial算子在调用之前，先转为float32类型，类似于： [GCU] Support llama for GCU #8445 。distributed_gather的地方，替换成distributed_allgather，类似于： xpu use allgather #8697 。