Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][Typos][S-[21-25]] Fix typos(shoud,shoule,Singal,simular,Similiar,Simle,signle) #70936

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 22, 2025

PR Category

User Experience

PR Types

Devs

Description

fixed:
shoud,shoule,Singal,simular,Similiar,Simle,signle

@paddle-bot paddle-bot bot added the contributor External developers label Jan 22, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 23, 2025
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

simular = 'simular'
Simle = 'Simle'
signle = 'signle'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这咋多出来一行,后面删掉

@@ -1863,7 +1863,8 @@ void ScatterInferMeta(const MetaTensor& x,
index_dims[0],
updates_dims[0],
common::errors::InvalidArgument(
"The first dimension size of Input(Index) shoud be no greater than "
"The first dimension size of Input(Index) should be no greater "
"than "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format 后这行只有一个词不太好看,后面可以和其他行拼在一起

@SigureMo SigureMo merged commit dbd9d0f into PaddlePaddle:develop Jan 23, 2025
31 checks passed
@SigureMo
Copy link
Member

❯ typos
error: `shoule` should be `should`
  --> ./paddle/fluid/inference/tensorrt/plugin/preln_residual_bias_plugin.cu:725:38
    |
725 |           "The input of swish plugin shoule not be nullptr."));
    |                                      ^^^^^^
    |
error: `payed` should be `paid`
  --> ./paddle/fluid/distributed/ps/thirdparty/round_robin.h:1582:17
     |
1582 |   // penalty is payed at the first insert, and not before. Lookup of this empty
     |                 ^^^^^
     |

@enkilee 还有一些漏了的,版本不对还是?现在 typos 是 1.29.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants