Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support npu kernel for expand_as_v2 op #34620

Merged
merged 9 commits into from
Aug 10, 2021

Conversation

rainyfly
Copy link
Contributor

@rainyfly rainyfly commented Aug 4, 2021

PR types

New features

PR changes

OPs

Describe

Support npu kernel for expand_as_v2 op
图片 1
image

@nepeplwu
Copy link
Contributor

nepeplwu commented Aug 5, 2021

LGTM

"expand_as_v2 op must be less than or equal to %d.",
target_rank, MAX_RANK_SUPPORTED));

switch (target_rank) { REP_EXPAND_AS_TEMPLATE(MAX_RANK_SUPPORTED) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 REP_EXPAND_AS_TEMPLATE 已经在 PR #34310 中被修改了,需要改一下,不然会编译错误

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 202c240 into PaddlePaddle:develop Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants