Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NPU] Support npu op: (1) cos (2) cos_grad #34573

Merged
merged 4 commits into from
Aug 5, 2021
Merged

[NPU] Support npu op: (1) cos (2) cos_grad #34573

merged 4 commits into from
Aug 5, 2021

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Aug 3, 2021 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

[NPU] Support npu op: (1) cos (2) cos_grad

  1. Add test_cos_op_npu.py for Unit tests.
  2. Register and implementation of cos npu、cos_grad npu in activation_op_npu.cc.

图片

图片

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 3, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@veyron95 veyron95 marked this pull request as draft August 3, 2021 04:14
@veyron95 veyron95 marked this pull request as ready for review August 3, 2021 04:17
@JiabinYang JiabinYang requested a review from qili93 August 3, 2021 07:12
@veyron95 veyron95 closed this Aug 3, 2021
@veyron95 veyron95 reopened this Aug 3, 2021
JiabinYang
JiabinYang reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment

veyron95
veyron95 commented Aug 5, 2021
View reviewed changes
Copy link
Contributor Author

@veyron95 veyron95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant {1} has been removed.

qili93
qili93 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 6151ccd into PaddlePaddle:develop Aug 5, 2021
@veyron95 veyron95 deleted the add_cos_op_npu branch November 12, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiabinYang JiabinYang JiabinYang left review comments

@qili93 qili93 qili93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veyron95 @CLAassistant @qili93 @JiabinYang