Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz: publish sensor_gps #24416

Closed
wants to merge 8 commits into from
Closed

Conversation

dakejahl
Copy link
Contributor

  • Disable sensor_gps_sim module in gz airframes (SENS_EN_GPSSIM 0)

  • Publish sensor_gps directly from GZBridge. Implemented first order markov process for GPS noise model.

  • Update gz models submodule to include updated IMU and Baro noise parameters
    Fix IMU + baro noise model PX4-gazebo-models#81

  • Removed mutex in gz topic callbacks. Callbacks run synchronously from gz and there are no shared resources with Run().

  • Removed hrt_absolute_time() == 0 check in topic callbacks. Not sure why it was there. If we need to validate that PX4-SITL has started before callbacks run we should do that before subscribing.

@dagar
Copy link
Member

dagar commented Feb 26, 2025

Disable sensor_gps_sim module in gz airframes (SENS_EN_GPSSIM 0)

Rather than setting it to 0 you should just not set it (off by default).

@dakejahl dakejahl force-pushed the pr-gz_sim_improvements branch from a7c3901 to fc91044 Compare February 26, 2025 17:28
@dakejahl dakejahl requested review from dagar and AlexKlimaj February 26, 2025 17:57
@dakejahl dakejahl force-pushed the pr-gz_sim_improvements branch from 52df4b9 to 492a3ef Compare February 26, 2025 18:27
@dakejahl
Copy link
Contributor Author

replaced by #24421

@dakejahl dakejahl closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants