improved checks, ToDos added #1872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge stable to develop
Merge stable into develop
* Tests added for remote sensing widget * Fixed flake8 * Flake8 fixed * Updated authors * AUTHORS updated * Fixed pytest errors * Issues resolved * Import order updated * Changes made * Update test_remotesensing.py * Data reorganized * Update test_remotesensing.py
Merge stable to develop
* added stuff * keyring tidy up * fixed some testcases * fixed keyring * added method to 'clear' keyring * split connect tests and added a '401' one for authorization denied case * adapted to comments * adapted to comments * renamed http_auth to mss_auth * removed misplaced http_basic_auth statment * updated keyring related documentation * updated status messages. * update * update
* fill mswms_settings with default values. * update
* preparing migration of json data to next major * flake8 * further changes * type fixed * new test for new migration * sample files updated * test improved * syntax fixe in sample
* individual imports better lookup by IDEs removed globals * flake8
* update super() calls to modern python * removed class ...(object)
* enable tests for GSOC branches * added a new testing action based on develop for gsoc * undo blank * var changed * name changed * removed unexpected value
…in mswms_settings.py (Open-MSS#1821)
* Make colorbar ticks format in generics plot configurable Fix Open-MSS#1828 * make vsec consistent with hsec * fix * fix
* introduction of group management * comment updated
Merge stable into develop
* on rename to a Group use import_permissions * flake8
joernu76
previously approved these changes
Aug 10, 2023
mslib/mscolab/server.py
Outdated
| @@ -482,12 +495,16 @@ def update_operation(): | |||
| def get_operation_details(): | |||
| op_id = request.args.get('op_id', request.form.get('op_id', None)) | |||
| user = g.user | |||
| result = str(fm.get_operation_details(int(op_id), user)) | |||
| if result is False: | |||
| return "False" | |||
| return json.dumps(fm.get_operation_details(int(op_id), user)) | |||
There was a problem hiding this comment.
get_operation_details is called twice here in the "normal" case.
There was a problem hiding this comment.
one too much, good catch
|
arg now something is going wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1871