renamed endpoint for mscolab authentification #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
reviewed
Jul 28, 2023
| @@ -203,7 +203,7 @@ def home(): | |||
| return render_template("/index.html") | |||
|
|
|||
|
|
|||
| @APP.route("/status") | |||
| @APP.route("/status_auth") | |||
| @conditional_decorator(auth.login_required, mscolab_settings.__dict__.get('enable_basic_http_authentication', False)) | |||
There was a problem hiding this comment.
I think this makes upcoming 9 consistent. It means also without /status any older version of msui knows to be outdated
We could also add a hint for that change into the 8.1.x
We could also use a complete different route name. /get_status, /info, /hello
There was a problem hiding this comment.
Correct, I think it can stay as this. A better name would maybe be "authenticate"? but the current one is fine. Any changes required?
There was a problem hiding this comment.
We remember this with the merge of the work from @nilupulmanodya
There was a problem hiding this comment.
Sure.. Thanks for remembering :)
ReimarBauer
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can "patch" the mscolab server to serve both 8.x and 9.x but do not need to. This can actually remain in develop, but we can remove it as well. I think it is better this way.