Fix updating hot cachelines cleaning list #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 62.85% 62.90% +0.05%
==========================================
Files 82 83 +1
Lines 9430 9447 +17
==========================================
+ Hits 5927 5943 +16
- Misses 3503 3504 +1
|
arutk
reviewed
Feb 9, 2021
src/engine/engine_wb.c
Outdated
| @@ -42,6 +43,9 @@ static void _ocf_write_wb_update_bits(struct ocf_request *req) | |||
|
|
|||
| ocf_req_hash_unlock_wr(req); | |||
| } | |||
|
|
|||
| if (ocf_engine_mapped_count(req) > 0) | |||
There was a problem hiding this comment.
So you will not call "set_hot" in case of full miss? I think it's incorrect.
There was a problem hiding this comment.
Ok, I've changed the code to call set_hot() unconditionally because I couldn't came up with any scenario when a write IO would be submitted in WB and the timestamp shouldn't be updated.
arutk
previously approved these changes
Feb 10, 2021
Update cacheline's timestamp each time it's being written. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
mmichal10
force-pushed
the
fix-cleaning
branch
from
0793c98 to
fa41d4f
Compare
arutk
approved these changes
Feb 10, 2021
jfckm
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cacheline's timestamp each time it's being written.
Fixes #455
Signed-off-by: Michal Mielewczyk michal.mielewczyk@intel.com