Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache lines' access timestamp in cleaning policy metadata not being updated #455

Closed
mmichal10 opened this issue Feb 5, 2021 · 0 comments · Fixed by #458
Closed

Cache lines' access timestamp in cleaning policy metadata not being updated #455

mmichal10 opened this issue Feb 5, 2021 · 0 comments · Fixed by #458
Assignees
Labels
bug Something isn't working

Comments

@mmichal10
Copy link
Contributor

mmichal10 commented Feb 5, 2021

ocf_cleaning_set_hot_cache_line() should be called each time a dirty cache line is accessed. Instead it is called only when the cache line is changing it's state from clean to dirty.

How to reproduce:

  • Start a cache in WB and configure alru casadm -X -n cleaning-alru -i 1 -w 0 -s 30 -b 100 -t 0
  • Issue writes to single cache line fio --name=nvme --numjobs=1 --iodepth=4 --bs=4k --rw=write --ioengine=libaio --direct=1 --group_reporting=1 --filename=/dev/cas1-1 --filesize=4k --runtime=60 --time_based=1
  • Dirty block flushes as soon as fio is completed

Expected result:

Dirty block flushed 30 seconds (--staleness-time 30) after fio is completed.

@mmichal10 mmichal10 added the bug Something isn't working label Feb 5, 2021
@mmichal10 mmichal10 self-assigned this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant