-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1057 trigger running foxx tests as part of ci #1096
1057 trigger running foxx tests as part of ci #1096
Conversation
Append to log file instead of rewriting
Add a bit of debug context
Update admin installation documentation
Feature 1005 - Consolidate development environment setup into admin scripts
…st cases if specified
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Release june 2024
1053 enable foxx tests in ci pipeline
…tup-container-to-stdout Add log output from ci end-to-end arango-setup job
…-node-setup-job 1073 add missing deployment key to node setup job
grab log output even if container fails
move flag to the correct position after ps
Reviewer's Guide by SourceryThis PR implements Foxx testing in the CI pipeline by modifying the entrypoint script to conditionally run tests when enabled. The changes include adding a new CMake option for Foxx testing, updating CI configuration to enable these tests, and improving container logging and error handling. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
00b0fcc
into
1055-fix-foxx-setup-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoshuaSBrown - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
================= | ||
|
||
Deploying DataFed requires building, installing, and configuring DataFed service as well as several | ||
third-party packages/services. The process described here is automated as much as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): There appears to be an extra space after 'automated'
Summary by Sourcery
Integrate Foxx tests into the CI pipeline, allowing them to be triggered conditionally based on the ENABLE_FOXX_TESTS environment variable. Update Docker entrypoint scripts to support this conditional testing and modify logging behavior to append rather than overwrite. Update documentation to include new installation instructions for Docker.
CI:
Documentation: