Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append to log file instead of rewriting #999

Merged

Conversation

theodore-s-beers
Copy link
Contributor

@theodore-s-beers theodore-s-beers commented Sep 10, 2024

As discussed in yesterday's meeting. There are two commits here, since I ran shfmt on the script for good measure, but I kept the meaningful change (adding -a) in a commit of its own.

Summary by Sourcery

Enhance the logging functionality by appending to the log file instead of overwriting it, and reformat the script for improved readability.

Enhancements:

  • Modify the logging mechanism to append to the log file instead of overwriting it, ensuring that log data is preserved across multiple runs.

Chores:

  • Reformat the script using 'shfmt' for consistent code style and readability improvements.

Copy link

sourcery-ai bot commented Sep 10, 2024

Reviewer's Guide by Sourcery

This pull request modifies the entrypoint script for a Docker container to append to the log file instead of rewriting it. Additionally, it applies formatting changes to improve code readability.

File-Level Changes

Change Details Files
Modify log file handling to append instead of overwrite
  • Add '-a' flag to 'tee' command to append to log file
  • Update comment to reflect the change in log file handling
repository/docker/entrypoint_repo.sh
Apply code formatting changes
  • Replace spaces with tabs for indentation
  • Remove unnecessary empty lines
  • Adjust line breaks and spacing for better readability
repository/docker/entrypoint_repo.sh

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @theodore-s-beers - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JoshuaSBrown
Copy link
Collaborator

Thanks @theodore-s-beers for doing this!

@JoshuaSBrown JoshuaSBrown self-assigned this Sep 11, 2024
@JoshuaSBrown JoshuaSBrown added the Type: Refactor Imlplementation change, same functionality label Sep 11, 2024
@JoshuaSBrown
Copy link
Collaborator

@theodore-s-beers can you please make a comment in the changelog.

@theodore-s-beers
Copy link
Contributor Author

Will do. Sorry I forgot that step. I'll push another commit to this branch today.

@JoshuaSBrown JoshuaSBrown merged commit 6ac6096 into ORNL:release_June_2024 Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Imlplementation change, same functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants