-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append to log file instead of rewriting #999
Append to log file instead of rewriting #999
Conversation
Reviewer's Guide by SourceryThis pull request modifies the entrypoint script for a Docker container to append to the log file instead of rewriting it. Additionally, it applies formatting changes to improve code readability. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @theodore-s-beers - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Thanks @theodore-s-beers for doing this! |
@theodore-s-beers can you please make a comment in the changelog. |
Will do. Sorry I forgot that step. I'll push another commit to this branch today. |
As discussed in yesterday's meeting. There are two commits here, since I ran
shfmt
on the script for good measure, but I kept the meaningful change (adding-a
) in a commit of its own.Summary by Sourcery
Enhance the logging functionality by appending to the log file instead of overwriting it, and reformat the script for improved readability.
Enhancements:
Chores: