Update Summary-Manager.Js #80
Open
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccar
reviewed
Mar 6, 2025
rmccar
reviewed
Mar 6, 2025
rmccar
reviewed
Mar 6, 2025
rmccar
reviewed
Mar 6, 2025
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-276
The New Version of Design System doesn't support
.ons-summary__row,.ons-summary__row--has-valuesanymore. (See this PR) This breaks the styling in summary page.This PR fixes class names. Also, instead of
<table>, I've used<dl>as summary component uses the dl tags. Let me know if that's okay.Also changed the param names -
row.rowTitletorow.titleandrow. rowItemstorow. itemsListas per the migration-guideHow to review this PR
Checkout to this PR in prototype-kit-template and copy these changes to Summary-Manager.Js file. See that these changes fix the styling in summary page.