Update Prototype Kit to Latest Version of Design System #11
+35
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admilne
reviewed
Mar 5, 2025
| @@ -8,9 +8,6 @@ Update the version in the path below to the version being used | |||
| /*********************************************************************** | |||
| Do not remove. Required for dynamic generation of survey summary page | |||
| ***********************************************************************/ | |||
| .ons-summary__item:not(:last-child) { | |||
| border-bottom: 1px solid var(--ons-color-borders) !important; | |||
| } | |||
There was a problem hiding this comment.
Why was this removed? The comment above suggests it shouldn't be removed?
There was a problem hiding this comment.
This style is already there in design system. I think this is not required anymore here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-276
This PR Updates the Prototype Kit Template to latest version of Design System.
This PR fixes class names. Also, instead of
<table>, I've used<dl>as summary component uses the dl tags. Let me know if that's okay.How to review this PR
Check that
@ons/design-systeminpackage.jsonis updated to72.4.0