-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testers.testBuildFailure': init #383511
Merged
ConnorBaker
merged 10 commits into
NixOS:master
from
ConnorBaker:feat/testBuildFailurePrime
Feb 27, 2025
Merged
testers.testBuildFailure': init #383511
ConnorBaker
merged 10 commits into
NixOS:master
from
ConnorBaker:feat/testBuildFailurePrime
Feb 27, 2025
+317
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
9b9ca0c
to
dea20ca
Compare
8e92398
to
f93587f
Compare
philiptaron
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot. The suggestion to make use of lib.customization.extendMkDerivation
is not blocking.
…o prevent lexical scoping mistakes
2dac118
to
d2a0e52
Compare
philiptaron
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: testing
Tooling for automated testing of packages and modules
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing tests for #383214, I was irritated by the amount of boilerplate to do simple things like check for the presence of strings in the builder's log or assert that the builder's exit code was some value.
This PR introduces
testBuildFailure'
, a wrapper around (and maybe eventually a replacement for)testBuildFailure
.An example of the rewrites
testBuildFailure'
enables, take a look at the tests in #383516 compared to the tests in #383214.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.