-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testers.testEqualArrayOrMap: init #383214
Open
ConnorBaker
wants to merge
10
commits into
NixOS:master
Choose a base branch
from
ConnorBaker:feat/testEqualArrayOrMap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+585
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f013c0
to
d94ee96
Compare
d94ee96
to
deb66f5
Compare
This was referenced Feb 19, 2025
deb66f5
to
095fc68
Compare
a5b1436
to
a527799
Compare
…upScript argument to script
a527799
to
becc932
Compare
e9a2721
to
179b96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: testing
Tooling for automated testing of packages and modules
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work I've done on rewriting the way CUDA software is packaged with Nix (https://github.com/ConnorBaker/cuda-packages) I made several testers, utility scripts, and setup hooks which I'm in the process of upstreaming.
This PR comes from https://github.com/ConnorBaker/cuda-packages/tree/18f4f5465272f6a88ed9bc660b3bc31dc01d4719/pkgs/by-name/mk/mkCheckExpectedArrayAndMap.
At its core, this PR introduces two utility functions declared in shell scripts,
assertEqualArray
andassertEqualMap
. While they may be included and used directly, they are meant to be used throughtesters.testEqualArrayOrMap
, as it provides an easy interface against which one can assert scripts populate bash arrays (including associative arrays, referred to as "maps" to disambiguate) with expected values.This tester has a number of uses and paves the way for more complicated array utilities, like those found here: https://github.com/ConnorBaker/cuda-packages/tree/18f4f5465272f6a88ed9bc660b3bc31dc01d4719/pkgs/by-name/ar/arrayUtilitiesHook.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.