-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
racket: refactor and add features, 8.14 -> 8.15, mark Darwin as badPlatforms
#365194
Conversation
e5451e8
to
137a24f
Compare
137a24f
to
b2fc71f
Compare
b2fc71f
to
e346012
Compare
e346012
to
0955c2e
Compare
0955c2e
to
6c5dbbe
Compare
68cc2f8
to
6bea8b3
Compare
6bea8b3
to
e0cf2f7
Compare
a8acf7d
to
9ac52fa
Compare
I haven't reviewed this PR in detail, but I wrote in #209660 (comment) about how we handle this in Guix. |
Thanks for directing me to the discussion. I do replace the |
badPlatforms
- Remove redundant dependencies and patch. (fix NixOS#246902) - Unify `pname` to `racket`. - Clean code.
Release note: https://blog.racket-lang.org/2024/11/racket-v8-15.html Close NixOS#360765.
badPlatforms
badPlatforms
@rc-zb @SuperSandro2000 did this PR change the distribution of |
Refactor
racket
andracket-minimal
.racket-minimal
by removing redundant dependencies. (fixing racket-minimal: closure size is too large #246902)pname
toracket
.Add features to Racket derivations.
writeScript[Bin]
.updateScript
.Update racket from 8.14 to 8.15 (alternative to racket: 8.14 -> 8.15 #360765, a trivial update on the version and hashes only).
Sadly, both this and racket: 8.14 -> 8.15 #360765 (and even the original recipe -- see Build failure: racket #372197) seem to fail to build on Darwin. I have to mark it as
badPlatforms
since I don't have a macOS device to test it.Add myself to the their maintainer list, which was empty until now.
Limitations
raco pkg
after installation, for lack of runtime dependencies. I don't know if this is part of the public interface of which all breaking changes must be documented.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.