Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: add package system support #373716

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

rc-zb
Copy link
Contributor

@rc-zb rc-zb commented Jan 14, 2025

Follows #375992.
Integrate the package system of Racket with Nixpkgs.

TODOs

  1. Pass racket-test.
    Current problems:
    • Fail to write to $out/share/doc/racket/acks/blueboxes.rktd
  2. Build the full distribution upon racket-minimal and the package system.
  3. Add more packages.

Limitations

  • To reduce time & space and gain power from the substitutes, it would be best if each Racket package were built separately like most of other packages in Nixpkgs. However, circular dependence, which is illegal for Nix early in evaluation time but accepted by Racket as long as they does not actually reference mutually in the code level (and for docs, even code level circles are allowed), is so common among these packages. As a result, racket.makePackage in this PR merely re-packs the original package into some canonical places, and it's the end user oriented racket.buildPackages and its tethered variant racket.withPackages that actually build them.
  • The layered installation mechanism of Racket is integrated with the package build system. However, since we can't get the complete list of transitive dependencies inside stdenv, only direct dependencies specified as buildInputs, depsHostHost and their propagated variants are included as layers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 14, 2025
@rc-zb rc-zb force-pushed the racket-pkg branch 3 times, most recently from 01bee16 to 40addde Compare January 17, 2025 16:13
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jan 17, 2025
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Jan 17, 2025
@rc-zb rc-zb force-pushed the racket-pkg branch 6 times, most recently from 56389ff to 3226d75 Compare January 20, 2025 19:11
@rc-zb rc-zb changed the title racket: add package system support racket: separate recipes, add unstable versions, add package system support Jan 20, 2025
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 20, 2025
@rc-zb rc-zb force-pushed the racket-pkg branch 3 times, most recently from 711b6d4 to b3c1b03 Compare January 22, 2025 08:29
@rc-zb rc-zb changed the title racket: separate recipes, add unstable versions, add package system support racket: separate recipes, fixup lack of SQLite, add package system support Jan 22, 2025
@rc-zb rc-zb mentioned this pull request Jan 23, 2025
13 tasks
@rc-zb rc-zb changed the title racket: separate recipes, fixup lack of SQLite, add package system support racket: add package system support Jan 23, 2025
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant