Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno_1: drop; deno: fix on x86_64-darwin #347974

Merged
merged 2 commits into from
Oct 16, 2024
Merged

deno_1: drop; deno: fix on x86_64-darwin #347974

merged 2 commits into from
Oct 16, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Oct 11, 2024

See commit messages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy force-pushed the push-mynotvkqyspv branch 3 times, most recently from d8ac5be to 627d690 Compare October 11, 2024 20:35
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 11, 2024
winterqt
winterqt requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry needs to be updated in first commit.

@emilazy
Copy link
Member Author

emilazy commented Oct 16, 2024

Done.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Oct 16, 2024
winterqt
winterqt approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilazy
deno_1: drop
bdad382 
Upstream do not plan to support this version (see
<NixOS#347484 (comment)>),
so we should not package a version that will surely accumulate CVEs
from V8 etc. in 24.11. As this package was only added yesterday,
I don’t think there’s any need for a compatibility alias.
@emilazy
deno: fix on x86_64-darwin
b97ec51 
It’s not clear to me what SDK version this actually ideally wants,
but `apple-sdk_11` is a conservative choice for now.
@emilazy emilazy changed the base branch from staging to staging-next October 16, 2024 00:56
@emilazy emilazy merged commit cd99542 into NixOS:staging-next Oct 16, 2024
12 of 16 checks passed
@emilazy emilazy deleted the push-mynotvkqyspv branch October 16, 2024 00:56
@natsukium natsukium mentioned this pull request Oct 19, 2024
Merged
13 tasks
@khaneliman khaneliman mentioned this pull request Oct 20, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt winterqt approved these changes

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilazy @winterqt