deno: 1.46.3 -> 2.0.0, deno_1: init at 1.46.3 #347484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06kellyjac
force-pushed
the
deno_v2
branch
4 times, most recently
from
3086d3e to
d786953
Compare
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: package (new)
Even better, an announcement video/live 2 hrs ago! https://www.youtube.com/watch?v=d35SlRgVxT8 |
Pattern of calling by-name sub-packages/versions seems already in use |
fabianhjr
approved these changes
Oct 9, 2024
|
nit: split into several commits (eg, the move of deno to deno_1 by-name, deno 2 init being separate commits) |
|
hey @06kellyjac ! Looks like you need to run nixfmt 👍🏻 |
|
Thanks Fabian. Less important but I've also changed the dir from Hi David, long time no see. |
Updates deno to v2. Slight refactor of fetcher code for grabbing librusty_v8. Updated the update scripts to use new Deno v2 interfaces and pull latest toml dependency from jsr rather than the deno.land registry. Added release note.
Add a pre v2 copy of deno as deno_1 to provide some stability until our next release and until 1.46 is fully abandoned soon. deno_1 is expected to be removed prior to 24.11. Added a release note.
|
restructured commits as described above. Formatting checks should pass 🙏 |
|
Some context for the PR and why the plan is to drop
If you would like to use |
fabianhjr
approved these changes
Oct 10, 2024
|
|
thank you :D |
|
We only have two weeks left before the 24.11 freeze, and it sounds like they’re not going to be doing security updates, so I’m going to drop Deno 1 immediately. In general we should not carry multiple versions of packages unless upstream plans to support them or there are severe compatibility problems, especially for packages where security is a concern. It’s not a good idea to introduce packages that will be removed soon after adding them. |
This comment was marked as resolved.
This comment was marked as resolved.
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Oct 11, 2024
Upstream do not plan to support this version (see <NixOS#347484 (comment)>), so we should not package a version that will surely accumulate CVEs from V8 etc. in 24.11. As this package was only added yesterday, I don’t think there’s any need for a compatibility alias.
|
I really need this update! |
1 task
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Oct 16, 2024
Upstream do not plan to support this version (see <NixOS#347484 (comment)>), so we should not package a version that will surely accumulate CVEs from V8 etc. in 24.11. As this package was only added yesterday, I don’t think there’s any need for a compatibility alias.
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Oct 16, 2024
Upstream do not plan to support this version (see <NixOS#347484 (comment)>), so we should not package a version that will surely accumulate CVEs from V8 etc. in 24.11. As this package was only added yesterday, I don’t think there’s any need for a compatibility alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Updates
denoto v2Adds a
deno_1to hold v1 for now.Depending on deno's support plans v1 may be removed just before the 24.11 release.
Updated the update scripts to use new Deno v2 interfaces and pull latest
toml dependency from jsr rather than the deno.land registry.
Note: need to double check it's ok to put
deno_1insidepkgs/by-name/deno/v1/package.nixNote: might wait a bit for the deno v2 announcement blog
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.