Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect neo_game_config, expand gamemode detection #769

Merged

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Oct 26, 2024

Description

  • Now reads in neo_game_config entity, just takes the number
  • OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
  • Mid-round voting is replaced by neo_sv_gamemode_enforcement
  • Add the gamemode name into the main menu in-game current server info
  • sv_neo_change_game_type_mid_round is now removed, now neo_sv_gamemode_enforcement 3 replaces that convar, but no longer mid-round, only from idle/warmup round
  • ConVars:
    • neo_sv_gamemode_enforcement - Default = 0 (map - neo_game_config), determine gamemode by... 0 = map (neo_game_config), 1 = neo_sv_gamemode_single, 2 = Random within neo_sv_gamemode_random_allow, 3 = vote (neo_vote_game_mode in idle/warmup)
    • neo_sv_gamemode_single - The single gamemode to enforce
    • neo_sv_gamemode_random_allow - The bitwise of gamemodes that is allowed to used for the randomizer

Toolchain

  • Linux GCC Distro Native [Specify distro + GCC version]

Linked Issues

@nullsystem nullsystem force-pushed the GH-723_GameModeChange branch from ef608aa to 07022e6 Compare October 26, 2024 16:47
@nullsystem nullsystem changed the title [WIP] Detect neo_game_config, change how game mode detection is done Detect neo_game_config, expand gamemode detection Oct 26, 2024
@nullsystem nullsystem marked this pull request as ready for review October 26, 2024 17:12
@nullsystem nullsystem force-pushed the GH-723_GameModeChange branch from 07022e6 to 2a54334 Compare October 26, 2024 17:13
@nullsystem nullsystem requested a review from a team October 26, 2024 17:20
brysondev
brysondev previously approved these changes Oct 26, 2024
@nullsystem nullsystem requested a review from a team October 26, 2024 21:04
@Rainyan Rainyan requested review from Rainyan and removed request for a team November 1, 2024 08:18
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* ConVars to change gamemode initalization behavior

* fixes NeotokyoRebuild#723
@nullsystem nullsystem requested a review from Rainyan November 2, 2024 13:43
Copy link
Collaborator

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nullsystem nullsystem merged commit 14c4282 into NeotokyoRebuild:master Nov 2, 2024
7 checks passed
@nullsystem nullsystem added this to the v10.0-prealpha milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game mode not detected with neo_game_config
3 participants