-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect neo_game_config, expand gamemode detection #769
Merged
nullsystem
merged 1 commit into
NeotokyoRebuild:master
from
nullsystem:GH-723_GameModeChange
Nov 2, 2024
Merged
Detect neo_game_config, expand gamemode detection #769
nullsystem
merged 1 commit into
NeotokyoRebuild:master
from
nullsystem:GH-723_GameModeChange
Nov 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef608aa
to
07022e6
Compare
07022e6
to
2a54334
Compare
brysondev
reviewed
Oct 26, 2024
brysondev
previously approved these changes
Oct 26, 2024
Rainyan
requested changes
Nov 1, 2024
* Now reads in neo_game_config entity, just takes the number * OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed * Mid-round voting no longer default * ConVars to change gamemode initalization behavior * fixes NeotokyoRebuild#723
2a54334
to
3a6f68d
Compare
brysondev
approved these changes
Nov 2, 2024
Rainyan
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
neo_game_config
entity, just takes the numberneo_sv_gamemode_enforcement
sv_neo_change_game_type_mid_round
is now removed, nowneo_sv_gamemode_enforcement 3
replaces that convar, but no longer mid-round, only from idle/warmup roundneo_sv_gamemode_enforcement
- Default = 0 (map - neo_game_config), determine gamemode by... 0 = map (neo_game_config), 1 =neo_sv_gamemode_single
, 2 = Random withinneo_sv_gamemode_random_allow
, 3 = vote (neo_vote_game_mode
in idle/warmup)neo_sv_gamemode_single
- The single gamemode to enforceneo_sv_gamemode_random_allow
- The bitwise of gamemodes that is allowed to used for the randomizerToolchain
Linked Issues