Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game mode not detected with neo_game_config #723

Closed
2 tasks done
Rainyan opened this issue Oct 13, 2024 · 0 comments · Fixed by #769
Closed
2 tasks done

Game mode not detected with neo_game_config #723

Rainyan opened this issue Oct 13, 2024 · 0 comments · Fixed by #769
Assignees
@nullsystem
Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub. current WIP Currently working on it
Milestone
Parity

Comments

@Rainyan
Copy link
Collaborator

Rainyan commented Oct 13, 2024 •
edited
Loading

Build Info

5426674

Description

In gamerules, we should determine the map's intended game mode via a neo_game_config entity, in parity with how original game determines its mode. The enumerations for this can be found in the NEOTOKYO/bin/neotokyo_pub.fgd:

@PointClass base(Angles) iconsprite("vgui/hud/kill_kill.vmt") = neo_game_config : "Game Config Entity"
[
	GameType(choices) : "Game Type (int)" : 0 : "More description here please..." =
	[
		0 : "TDM"
		1 : "CTG"
		2 : "VIP"
	]	

]

To Reproduce

  • Launch a map in a server
  • Observe the game mode set by gamerules

Expected behavior

Game mode follows neo_game_config logical entity.

Actual behavior

neo_game_config is an unknown entity classname. Game mode does not follow its value.

Operating System

  • Windows
  • Linux

Version/Distro

N/A

Machine's CPU

No response

Machine's GPU

No response

GPU's driver

No response

Build's compiler

No response

Additional context and Screenshots

We also have a custom game mode voting feature currently in the game, which I suppose could be preserved as an override for the default game mode determined by gamerules at map load.
@Rainyan Rainyan added the Bug Report Bug Reports made through the "Report Issue" interface in GitHub. label Oct 13, 2024
@kassibuss kassibuss added this to the Parity milestone Oct 13, 2024
@nullsystem nullsystem self-assigned this Oct 26, 2024
@nullsystem nullsystem moved this to In Progress in Bug Bounty Oct 26, 2024
@nullsystem nullsystem added the current WIP Currently working on it label Oct 26, 2024
nullsystem added a commit to nullsystem/neo that referenced this issue Oct 26, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
583a67e 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* TODO: Type of server usage of gamemode convar

* fixes NeotokyoRebuild#723
nullsystem added a commit to nullsystem/neo that referenced this issue Oct 26, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
1ca3f1e 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* TODO: Type of server usage of gamemode convar

* fixes NeotokyoRebuild#723
nullsystem added a commit to nullsystem/neo that referenced this issue Oct 26, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
ef608aa 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* TODO: Type of server usage of gamemode convar

* fixes NeotokyoRebuild#723
@nullsystem nullsystem mentioned this issue Oct 26, 2024
Merged
nullsystem added a commit to nullsystem/neo that referenced this issue Oct 26, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
07022e6 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* ConVars to change gamemode initalization behavior

* fixes NeotokyoRebuild#723
nullsystem added a commit to nullsystem/neo that referenced this issue Oct 26, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
2a54334 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* ConVars to change gamemode initalization behavior

* fixes NeotokyoRebuild#723
nullsystem added a commit to nullsystem/neo that referenced this issue Nov 2, 2024
@nullsystem
Game mode detect neo_game_config, change defaults
3a6f68d 
* Now reads in neo_game_config entity, just takes the number
* OG:NT + NT;RE already maps 0=TDM,1=CTG,2=VIP, so no conversion needed
* Mid-round voting no longer default
* ConVars to change gamemode initalization behavior

* fixes NeotokyoRebuild#723
@blaberry blaberry moved this from In Progress to Done in Bug Bounty Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullsystem nullsystem

Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub. current WIP Currently working on it
Projects
Bug Bounty
Status: Done
Milestone
Parity
Development

Successfully merging a pull request may close this issue.

Detect neo_game_config, expand gamemode detection nullsystem/neo
3 participants
@Rainyan @nullsystem @kassibuss