Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill feed - Change to neuropol2 font, white color separator #493

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Jul 7, 2024

Description

  • OGNT killfeed font is neuropol2
  • Removed unneeded ClientScheme_KillFeed.res
  • Refactor a bit to just use the string directly

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

Screenshot

killfeedwassistneuropol

@nullsystem nullsystem force-pushed the GH-442_KillFeedFont branch from 170e416 to e2a1a9e Compare July 7, 2024 11:30
AdamTadeusz

This comment was marked as outdated.

AdamTadeusz
AdamTadeusz previously approved these changes Jul 10, 2024
@AdamTadeusz AdamTadeusz requested a review from a team July 10, 2024 19:34
* OGNT killfeed font is neuropol2
* Removed unneeded ClientScheme_KillFeed.res
* Refactor a bit to just use the string directly
* fixes NeotokyoRebuild#442
@AdamTadeusz AdamTadeusz requested a review from a team July 19, 2024 15:46
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Agiel
Copy link
Contributor

Agiel commented Jul 19, 2024

Not going to stop this PR but we should migrate back to using ClientScheme.res instead of ClientScheme_Neo.res

@nullsystem
Copy link
Collaborator Author

Not going to stop this PR but we should migrate back to using ClientScheme.res instead of ClientScheme_Neo.res

Create new GH issue: #515

@nullsystem nullsystem merged commit 891ea17 into NeotokyoRebuild:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assists in killfeed should have a clearer separator
4 participants