Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ClientScheme_Neo.res with ClientScheme.res #515

Closed
nullsystem opened this issue Jul 19, 2024 · 0 comments · Fixed by #516
Closed

Replace ClientScheme_Neo.res with ClientScheme.res #515

nullsystem opened this issue Jul 19, 2024 · 0 comments · Fixed by #516
Assignees
@nullsystem
Labels
refactor Code refactor

Comments

@nullsystem
Copy link
Collaborator

ClientScheme_Neo.res is practically a duplication of ClientScheme.res. Anything that the _Neo version has should be merged into non-_Neo and all usages of _Neo version moved off to non-_Neo version then remove ClientScheme_Neo.res.
@nullsystem nullsystem added the refactor Code refactor label Jul 19, 2024
@nullsystem nullsystem self-assigned this Jul 19, 2024
@nullsystem nullsystem mentioned this issue Jul 19, 2024
Merged
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 20, 2024
@nullsystem
Replace ClientScheme_Neo with ClientScheme
b72f411 
* Merged in whatever ClientScheme_Neo has into ClientScheme
* fixes NeotokyoRebuild#515
@nullsystem nullsystem mentioned this issue Jul 20, 2024
Merged
nullsystem added a commit to nullsystem/neo that referenced this issue Jul 20, 2024
@nullsystem
Replace ClientScheme_Neo with ClientScheme
c468753 
* Merged in whatever ClientScheme_Neo has into ClientScheme
* fixes NeotokyoRebuild#515
nullsystem added a commit that referenced this issue Jul 22, 2024
@nullsystem
Replace ClientScheme_Neo with ClientScheme (#516)
3578f5d 
* Merged in whatever ClientScheme_Neo has into ClientScheme
* fixes #515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullsystem nullsystem

Labels
refactor Code refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ClientScheme_Neo with ClientScheme nullsystem/neo
1 participant
@nullsystem