forked from NCAR/ccpp-physics
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE! Highlights the RRFS_dev diffs #168
Draft
christinaholtNOAA
wants to merge
77
commits into
dev_tmp_rrfs_merge
Choose a base branch
from
rrfs_dev_merge
base: dev_tmp_rrfs_merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Spring Experiment. 2) Set allow_wet_snow = .true. allow_wet_graupel = .false. melti=.true. for all steps.
RRFS_dev: fix problems in reflectivity diagnosis for Thompson scheme.
…o old version In ruclsm: a tuning In module_sf_mynn.F90: remove NSST.
Put several hot fix to ccpp for RRFS 2022 HWT
…small-scale GWD and TOFD
Modified physics/drag_suite.F90 to remove topographic limitations on small-scale GWD and TOFD
…FS_dev-20220314 Merge gsl/develop to RRFS_dev
1. Added lat/lon to the parameter list for debugging purposes. 2. Flag_restart is replaced with lsm_cold_start. 3. Removed snow initialization with the use of RUC LSM. In case of cold start snow on land andice is initialized in io/FV3GFS_io.F90. In case of warm start, these variables are carried along. 3. Corresponding changes in GFS_surface_composites.meta.
The change gets around snow initialization with the use of RUC LSM
…ites_bugfixes Bug fixes to drag_suite.F90 and GFS_surface_composites.F90
merging MYNN mods from gsl/develop
…s a flux-based diagnostics. This diagnostics will be enabled when MYNN surface layer scheme and RUC LSM are used in the physics suite, for example FV3_HRRR suite. 2. In sfc_drv_ruc.F90 several variables are added to the output. They include such variables as variable-density snow accumulation, accumulated snow melt, latent heat flux due to snow phase changes, sublimation, direct evaporation, canopy evaporation and transpiration fluxes. Fixed units of runoff variables. 3. Cleaned-up print statements. Introduced a test point with lat/lon for debugging in sfc_diag.f, sfc_drv_ruc.F90 and module_sf_ruclsm.F90. 4. Several modifications to the snow model in module_sf_ruclsm.F90. Introduced two options to compute snow fraction and thermal conductivity in snow. The new options are disabled until their impact is evaluated in the retrospective experiments.
Added Glacier land-use type to set_soilveg_ruc.F90
snow and rain reaching the groundd.
Zero out snowfallacc_lnd/ice at the beginning of the free forecast.
Removed zeroing out the state variables at the beginning of the forecast.
Merge gsl/develop into RRFS_dev
…sue during DEBUG=ON)
…to "snow on ice" as well
RUC LSM precision workaround
Bug fixes to prevent crashes and other failures.
Unify the FV3-HRRR and FV3-HRRR-smoke
1) add a special treatment to melting hail on the ground after hail storm. 2) moved parameter for snow over and conductivity definition to the top
update physics for RRFS baseline E
update smoke emission reading and direct feedback
zhanglikate
pushed a commit
to zhanglikate/ccpp-physics
that referenced
this pull request
Apr 5, 2024
…pliant Make ozone physics CCPP compliant by removing 'optional' and 'pointer' attributes (includes NOAA-GSL#168 and NOAA-GSL#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant as an open forum to discuss differences that we have in the RRFS_dev branch.
We will use this comparison to isolate features that will be contributed to the real develop branch.
This PR is for demo purposes only!