update physics for RRFS baseline E #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) add a special treatment to melting hail on the ground after hail storm. 2) moved parameter for snow over and conductivity definition to the top
hu5970
requested review from
SamuelTrahanNOAA,
tanyasmirnova,
christinaholtNOAA,
joeolson42,
hannahcbarnes,
mdtoyNOAA,
haiqinli,
zhanglikate and
middlecoff
as code owners
This was referenced Oct 10, 2022
hannahcbarnes
approved these changes
Oct 10, 2022
tanyasmirnova
approved these changes
Oct 10, 2022
haiqinli
approved these changes
Oct 10, 2022
joeolson42
approved these changes
Oct 11, 2022
SamuelTrahanNOAA
requested changes
Oct 11, 2022
mdtoyNOAA
approved these changes
Oct 11, 2022
|
Everyone please examine the diffs more carefully. The line that is failing (5353 of module_bl_mynn.F90) was apparently not supposed to be in the PR, and was inserted by accident during a merge. There may be more such errors. |
SamuelTrahanNOAA
requested review from
joeolson42,
haiqinli,
tanyasmirnova,
mdtoyNOAA and
hannahcbarnes
tanyasmirnova
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@SamuelTrahanNOAA I reviewed RUC lsm and surface layer MYNN changes, and everything looks good to me.
joeolson42
approved these changes
Oct 11, 2022
mdtoyNOAA
approved these changes
Oct 11, 2022
zhanglikate
approved these changes
Oct 11, 2022
SamuelTrahanNOAA
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MYNN and RUCLSM were updated. The code has been tested with retros.
This PR includes three parts:
1) add a special treatment to melting hail on the ground after hail storm.
2) moved parameter for snow over and conductivity definition to the top