-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW3: Add indicator log file for gridded output #3304
WW3: Add indicator log file for gridded output #3304
Conversation
…t/production/GFS.v16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to use new .FINISHED
log file look good. I appreciate the extra space cleanup as well. Leaving a comment to change the ufs-weather-model tag name once those PRs are done and a new tag is cut. Please re-request a review from me once the tag is updated in both sorc/checkout.sh
and Externals.cfg
. Thanks!
FYI @ADCollard, we will be merging a WW3 update into the GFSv16.4 release branch with this PR. |
@KateFriedman-NOAA - Are there other model changes in 16.4 or is this it? |
This is it so far in terms of ufs-weather-model updates for v16.4. GFSv16.4 was originally a DA-only upgrade to bring |
Thanks @KateFriedman-NOAA - Just wanted to make sure before we started asking for tags, etc. |
@KateFriedman-NOAA The tag has been created and added to this PR. Do you want any release notes updates? We can always add info in a second PR if needed to make things simpler. |
Thanks for the update @JessicaMeixner-NOAA ! Regarding the release notes, I will PR updates for that into @MatthewMasarik-NOAA 's PR branch. Stay tuned... |
Opened a PR into @MatthewMasarik-NOAA 's PR branch to add the initial release notes: MatthewMasarik-NOAA#1 @MatthewMasarik-NOAA @JessicaMeixner-NOAA after you merge in my PR, please scan the updated release notes, add your name(s) to the bottom of it, and update any WW3-related details as needed. Thanks! |
- create initial skeleton for GFSv16.4 release notes - add WW3 script and ufs-weather-model tag updates Refs NOAA-EMC#3094
@KateFriedman-NOAA I was curious if the current description you have for the WW3 related changes is the level of detail that's wanted here, or should any more description be added? |
I spoke with @JessicaMeixner-NOAA offline about this and have an update I will push but up here momentarily. |
I added a short snippet for the WW3 related changes and our names. @KateFriedman-NOAA @JessicaMeixner-NOAA please check though in case any edits are needed. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the extra WW3 details in the release notes @MatthewMasarik-NOAA !
Sure thing! Thank you @KateFriedman-NOAA. |
Description
Adds the functionality to write an indicator log file which will signal gridded output has completed writing for a given grid and timestep (Issue #3094)
Resolves #3094
Refs ufs-community/ufs-weather-model#2545
Refs NOAA-EMC/WW3#1321
Reviewer(s): @KateFriedman-NOAA
Type of change
Change characteristics
How has this been tested?
Clone, build, and run forecast-only on WCOSS2.
Checklist