Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW3: Add indicator log file for gridded output #3304

Conversation

MatthewMasarik-NOAA
Copy link

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Feb 5, 2025

Description

Adds the functionality to write an indicator log file which will signal gridded output has completed writing for a given grid and timestep (Issue #3094)

Resolves #3094
Refs ufs-community/ufs-weather-model#2545
Refs NOAA-EMC/WW3#1321

Reviewer(s): @KateFriedman-NOAA

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES (a new file log file is written)
  • Does this change require a documentation update? YES
  • Does this change require an update to any of the following submodules? YES (WW3 within UFS-weather-model is updated)

How has this been tested?

Clone, build, and run forecast-only on WCOSS2.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to use new .FINISHED log file look good. I appreciate the extra space cleanup as well. Leaving a comment to change the ufs-weather-model tag name once those PRs are done and a new tag is cut. Please re-request a review from me once the tag is updated in both sorc/checkout.sh and Externals.cfg. Thanks!

@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Feb 5, 2025
@KateFriedman-NOAA
Copy link
Member

FYI @ADCollard, we will be merging a WW3 update into the GFSv16.4 release branch with this PR.

@JessicaMeixner-NOAA
Copy link
Contributor

@KateFriedman-NOAA - Are there other model changes in 16.4 or is this it?

@KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA - Are there other model changes in 16.4 or is this it?

This is it so far in terms of ufs-weather-model updates for v16.4. GFSv16.4 was originally a DA-only upgrade to bring develop GSI into production to help reduce work for GFSv17. See related issues #2987 and #3045. This will be a multi-component update now.

@JessicaMeixner-NOAA
Copy link
Contributor

Thanks @KateFriedman-NOAA - Just wanted to make sure before we started asking for tags, etc.

@JessicaMeixner-NOAA
Copy link
Contributor

@KateFriedman-NOAA The tag has been created and added to this PR. Do you want any release notes updates? We can always add info in a second PR if needed to make things simpler.

@KateFriedman-NOAA
Copy link
Member

Thanks for the update @JessicaMeixner-NOAA ! Regarding the release notes, I will PR updates for that into @MatthewMasarik-NOAA 's PR branch. Stay tuned...

@KateFriedman-NOAA
Copy link
Member

Opened a PR into @MatthewMasarik-NOAA 's PR branch to add the initial release notes: MatthewMasarik-NOAA#1

@MatthewMasarik-NOAA @JessicaMeixner-NOAA after you merge in my PR, please scan the updated release notes, add your name(s) to the bottom of it, and update any WW3-related details as needed. Thanks!

- create initial skeleton for GFSv16.4 release notes
- add WW3 script and ufs-weather-model tag updates

Refs NOAA-EMC#3094
@MatthewMasarik-NOAA
Copy link
Author

MatthewMasarik-NOAA commented Feb 11, 2025

add your name(s) to the bottom of it, and update any WW3-related details as needed.

please scan the updated release notes, add your name(s) to the bottom of it, and update any WW3-related details as needed.

@KateFriedman-NOAA I was curious if the current description you have for the WW3 related changes is the level of detail that's wanted here, or should any more description be added?

@MatthewMasarik-NOAA
Copy link
Author

add your name(s) to the bottom of it, and update any WW3-related details as needed.

please scan the updated release notes, add your name(s) to the bottom of it, and update any WW3-related details as needed.

@KateFriedman-NOAA I was curious if the current description you have for the WW3 related changes is the level of detail that's wanted here, or should any more description be added?

I spoke with @JessicaMeixner-NOAA offline about this and have an update I will push but up here momentarily.

@MatthewMasarik-NOAA
Copy link
Author

I added a short snippet for the WW3 related changes and our names. @KateFriedman-NOAA @JessicaMeixner-NOAA please check though in case any edits are needed. Thank you

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the extra WW3 details in the release notes @MatthewMasarik-NOAA !

@KateFriedman-NOAA KateFriedman-NOAA merged commit 28184a8 into NOAA-EMC:release/gfs.v16.4 Feb 12, 2025
1 check failed
@MatthewMasarik-NOAA
Copy link
Author

Looks good, thanks for the extra WW3 details in the release notes @MatthewMasarik-NOAA !

Sure thing! Thank you @KateFriedman-NOAA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants