Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator log file for gridded output in production/GFS.v16 #1347

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Jan 16, 2025

Pull Request Summary

Adds the writing of a log file to indicate that a particular gridded output file has finished writing.

Description

  • Provide a detailed description of what this PR does.

    • This indicator file will be used to signal to the post-processing scripts that a gridded output file is ready to be accessed and read. This is implemented in a simple way by reusing the Fortran IO unit number for the gridded output once that file has already been closed (thanks to @JessicaMeixner-NOAA for the suggestion!).
  • What bug does it fix, or what feature does it add?

    • This fixes an infrequent occurrence in the global-workflow where a gridded output file has an attempted read on it before the file has completed writing.
  • Is a change of answers expected from this PR?

    • No. This just addresses an issue that has occurred in post-processing.

Please also include the following information:

  • Add any suggestions for a reviewer
  • Mention any labels that should be added:
    • bug.
  • Are answer changes expected from this PR?
    • No.

Issue(s) addressed

Commit Message

w3iogomd.ftn: Add indicator log file write for gridded output

Check list

Testing

  • How were these changes tested?
    • Testing during development was done in standalone mode with a modified regtest which is verified by a separate process checking for out_grd files and indicator files.
    • Final testing was performed within global-workflow:dev/gfs.v16 and passed b4b.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • N/A.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • No. It is not a requirement for the production/GFS.v16 branch.
    • Functionality and b4b were confirmed in the global-workflow testing.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • No changes expected, though indicator logs will now be present in the run directory.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • Not required for production/GFS.v16.

* production/GFS.v16:
  GFSv16 optimized point output (NOAA-EMC#1355)
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update @MatthewMasarik-NOAA

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 730817e into NOAA-EMC:production/GFS.v16 Feb 10, 2025
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/WW3 that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants