-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring data usage up to GFS v16.3.12 #13
Conversation
…, and global_satinfo.txt * Turn on Himawari-8 and Himawari-9 Clear Sky Radiances * Turn on NOAA-21 CrIS and NOAA-21 ATMS radiances * Turn on GOES-18 Clear Sky Radiances * Turn on Metop-C ASCAT surface winds
I cannot assign people to this PR, so I am explicitly tagging people here: @KateFriedman-NOAA @RussTreadon-NOAA @emilyhcliu @HaixiaLiu-NOAA (@ClaraDraper-NOAA for information) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, the changes look to be what I expect for turning on assimilation of NOAA21 (e.g. -1
to 1
switch updates). Beyond that, I will defer to DA developer reviews for the correctness of the changes. I approve but am not the final say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only one question about state_vector_efsoi
section in global_anavinfo.l127.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only review this in terms of impact on my soil analysis changes, and there are no issues on that front.
@ADCollard , would you please add
back into Once this is done, we can merge this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Approve
Modifications to
global_anavinfo.l127.txt
,global_convinfo.txt
, andglobal_satinfo.txt
to turn on Himawari-8 and -9 clear sky radiances; GOES-18 clear sky radiances; NOAA-21 CrIS and ATMS radiances; and Metop-C scatterometer winds.This includes the relevant changes to GSI branch release/gfsda.v16 from the following commits.
The new file
Rcov_crisn21
is a binary and will need to be added separately.