Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sfc flux spec #71

Merged
merged 3 commits into from
May 31, 2018
Merged

Add sfc flux spec #71

merged 3 commits into from
May 31, 2018

Conversation

grantfirl
Copy link
Collaborator

This PR adds functionality to the SCM to use prescribed surface fluxes. A new SDF was added that bypasses the surface schemes and a new "scheme" was added to the schemes in the prebuild script configuration. This PR is in conjunction with PRs for ccpp-physics and gmtb-scm.

@grantfirl grantfirl requested review from llpcarson and climbfuji May 30, 2018 22:19
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging this will cause a conflict for my pending PR #70 but that's ok. When #70 goes in, we will also have to update GFS_init_scm and GFS_finalize_scm: the two modules need to be combined into one and the run routines must become the _init and _finalize routines instead (_run stays empty).

@grantfirl
Copy link
Collaborator Author

Thanks, Dom. I would suggest that we wait to merge #71 until #70 is in. I'll make the required changes once #70 is in.

@grantfirl grantfirl merged commit 7e1a995 into master May 31, 2018
@grantfirl grantfirl deleted the add_sfc_flux_spec branch May 31, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants