CCPP run _init and _final for schemes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_physics_init after an optional/additional init routine XXX specified as <init>XXX</init> in the SDF. For XXX, only the XXX_init function is used, unless XXX is also specified as additional finalize routine. Similarly, all scheme _finalize routines are run as part of ccpp_physics_finalize, before an optional/additional finalize routine YYY specified as <finalize>YYY</finalize> in the SDF. For YYY, only the YYY_finalize function is used, unless YYY=XXX (in which case both XXX_init and XXX_finalize are used). merge with 9f2e0f7
…s _init, _run and _finalize to the scheme names to determine the function names
|
This PR goes together with NCAR/ccpp-physics#86 and must go in before any further development can be made from my side with respect to CCPP in NEMSfv3gfs (i.e. CCPP-compliant cnvc90.f). |
grantfirl
approved these changes
May 30, 2018
There was a problem hiding this comment.
This code looks good to me, although I would benefit from a brief overview of the changes if we meet tomorrow. As Dom mentioned in PR #71, the new SDF introduced therein will need to be modified to follow what this PR requires.
Merged
|
Thanks @grantfirl I agree with your suggested approach. |
This was referenced May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates out the changes to ccpp-framework in PR #69 that enable running the XXX_init and XXX_finalize routines automatically for every scheme listed in the SDF.
In addition, a suite-specific scheme YYY can be used, for which the YYY_init and YYY_finalize routines can be run explicitly before (init) and after (finalize) the scheme init and finalize routines are run:
The above snippet will run:
This PR was tested to work and is ready to review and merge.