-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two cupid_webpage fixes #201
Conversation
1. Depending on how your environment is configured, you either need to import util or cupid.util (and git_helper or cupid.git_helper); added try / except blocks for both imports 2. Don't update github_pages_dir to a realpath unless it is non-empty (want to keep default behavior of not doing anything if user doesn't specify -g option; I was getting RuntimeError: When specifying -g/--github-pages-dir, you must also provide -n/--name even when not specifying -g)
@dabail10 reported this issue, and I was able to recreate it locally. My testing was just to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in my sandbox and it worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that! Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnlevy1981 ! I tested both the -g and regular options, and everything worked as expected (commands were cupid-webpage
and cupid-webpage -g ../../../../samr_cupid/land_cupid_publish_test -n landtest13
). Sounds like you're also testing in the CESM workflow, so I'll let you double check that one.
I verified that the CESM Workflow showed the same
reported in #200, but switching to this branch fixed it. |
util
orcupid.util
(andgit_helper
orcupid.git_helper
); added try / except blocks for both importsgithub_pages_dir
to arealpath
unless it is non-empty (want to keep default behavior of not doing anything if user doesn't specify-g
option; I was gettingeven when not specifying
-g
)Description of changes:
All PRs Checklist:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?