Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cupid-webpage arguments should not force users to upload to github #200

Closed
TeaganKing opened this issue Mar 7, 2025 · 0 comments · Fixed by #201
Closed

Default cupid-webpage arguments should not force users to upload to github #200

TeaganKing opened this issue Mar 7, 2025 · 0 comments · Fixed by #201
Assignees
@TeaganKing
Labels
bug Something isn't working common utility high priority

Comments

@TeaganKing
Copy link
Collaborator

TeaganKing commented Mar 7, 2025 •
edited
Loading

Description of the Bug
When running cupid-webpage without the -g argument, users receive a RunTimeError with a request to specify a --name argument. However, the default cupid-webpage should not ask users to upload their results to github pages for sharing purposes. This bug was introduced in #195 .

To Reproduce
Run cupid-webpage.

Expected behavior
Create jupyterbook html in computed_notebooks directory.

Additional context
PR coming soon... Sorry I should have caught this while reviewing!
Also notifying @samsrabin of this bug.
@TeaganKing TeaganKing self-assigned this Mar 7, 2025
@TeaganKing TeaganKing linked a pull request Mar 7, 2025 that will close this issue
Two cupid_webpage fixes #201
Merged
5 tasks
@mnlevy1981 mnlevy1981 mentioned this issue Mar 7, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeaganKing TeaganKing

Labels
bug Something isn't working common utility high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Two cupid_webpage fixes mnlevy1981/CUPiD
1 participant
@TeaganKing