Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltips on elements that have keyboard focus #52016

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 16 comments
Closed

Show tooltips on elements that have keyboard focus #52016

AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 16 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS
Copy link

AccessibilityTestingTeam-TCS commented Jun 15, 2018

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
MAS Violated: MAS2.1.1,MAS1.1.1

GitHubTags: #A11yMAS; #A11yTCS; #Win32; #DesktopApp #A11y_VSCodeEditor #WCAG2.1.1 #WCAG1.1.1

Repro Steps:

  1. Launch VS Code.
  2. Go to View menu and Select Problems.
  3. Tab till collapse button beside Filter textbox in Problems Tab.

Actual:
Tooltip of buttons(Collapse,Minimize Panel Size, Move to right, Close Panel) in the Problems tab are not available when we navigate using keyboard. Tooltips are only available on mouse hover.

Expected:
When keyboard focus goes on control and for that control if tooltip is present then on keyboard focus tooltip should also appear.

User Impact:
Keyboard only users wont get the information which are conveyed through tooltip.

Attachment for Reference:
A11y VSCode Problems NVDA Tooltipnotaccessible.pptx

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane RMacfarlane added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 15, 2018
@sandy081 sandy081 assigned bpasero and unassigned sandy081 Jun 18, 2018
@sandy081
Copy link
Member

Assigning to @bpasero as this might impact all workbench actions

@bpasero
Copy link
Member

bpasero commented Jun 18, 2018

@AccessibilityTestingTeam-TCS I cannot reproduce, when I tab over the buttons I get the following:

image

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 18, 2018
@vscodebot
Copy link

vscodebot bot commented Jun 25, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jun 25, 2018
@AccessibilityTestingTeam-TCS
Copy link
Author

Please refer video attached in the "Attachment for Reference" section. @bpasero I think you are using screenreader that's why it is displaying the tooltip. This issue is only regarding keyboard. On keyboard focus, tooltip should be visible.

@bpasero bpasero reopened this Jun 26, 2018
@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

We do not control that, it is the native tooltip.

@bpasero bpasero removed the info-needed Issue requires more information from poster label Jun 26, 2018
@bpasero bpasero changed the title [Accessibility]A11y_VSCode_ViewProblems_Keyboard: Tooltip of buttons(Collapse,Minimize Panel Size, Move to right, Close Panel)are not available on keyboard focus Show tooltips on elements that have keyboard focus Jun 26, 2018
@bpasero
Copy link
Member

bpasero commented Jun 29, 2018

@isidorn fyi umbrella bug

@isidorn
Copy link
Contributor

isidorn commented Jun 29, 2018

@bpasero thanks

@bpasero bpasero added the feature-request Request for new features or functionality label Sep 11, 2018
@bpasero bpasero removed their assignment Sep 11, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added this to the Backlog milestone Jun 18, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 18, 2019

@bpasero if we introduced some setting for this. Is there some way for us to always trigger the hover as the focus moves.

@bpasero
Copy link
Member

bpasero commented Jun 18, 2019

@isidorn to my knowledge you cannot programmatically trigger the native tooltip in the browser

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 19, 2019
@isidorn isidorn added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 25, 2019
@isidorn isidorn self-assigned this Oct 8, 2019
@nirmalsahoo
Copy link

nirmalsahoo commented May 7, 2020

@isidorn Same issue is observed in below vs code version.It is reproduced for all the controls for which the tooltips are visible by mouse but not by Keyboard.
Version: 1.44.2 (user setup)
Commit: ff91584
Date: 2020-04-16T16:36:23.138Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@MayuriNaik
Copy link

@isidorn Same issue is observed in below vs code version. It is reproduced for all the controls for which the tooltips are visible by mouse but not by Keyboard.
Version: 1.41.0-insider
Commit: 9579eda
Date: 2019-12-10T21:42:59.146Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: MAC_Darwin x64 19.5.0

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

From the user perspective we already read the aria label of the element once the user navigates on it. Aria label is usually the same as what is hovered or better, so this issue is covered for blind users.
The only users this makes sense for imho are users who can not use the mouse and are not using a screen reader. Thus they navigate using the keyboard to an action and they would like to know more details about that action. So it would be nice to have an explicit command to trigger this native hover for those users. However web browsers do not support this as far as I know and it is not possible to trigger a native hover.

We can maybe look into this once MS Teams starts supporting this.
The only solution I see is to build a custom hover which I would not do for a feature which none of the users requested.

@Tanushagottipati
Copy link

Tanushagottipati commented Jul 23, 2020

GitHubTags: #A11ySev2;

@isidorn
Copy link
Contributor

isidorn commented Sep 16, 2020

As per my comment above and because none of our users ever requested this I am closing this as designed. We will not change this.

@isidorn isidorn closed this as completed Sep 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
@isidorn isidorn added macos Issues with VS Code on MAC/OS X windows VS Code on Windows issues and removed macos Issues with VS Code on MAC/OS X labels Jan 27, 2022
@isidorn
Copy link
Contributor

isidorn commented Feb 28, 2022

Duplicate of #132344

@isidorn isidorn marked this as a duplicate of #132344 Feb 28, 2022
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

9 participants